Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cursor line rendering to the Build Analyzer chart and fixed .env.example #1848

Closed
wants to merge 3 commits into from

Conversation

ElementUser
Copy link
Contributor

@ElementUser ElementUser commented Aug 24, 2024

Issue Link: #1806

Description of Changes

Added cursor line rendering to the Build Analyzer chart when a data point is selected (default value for this option is false when not specified)

  • Also fixed an "Invalid URL" error when following the README instructions & running the application locally (by adding the BASE_URL field to .env.example)

==

This is how the Build Analyzer chart looks like after the change when hovering over the chart:

image

…oint is selected

- Also fixed an "Invalid URL" error when following the README instructions & running the application locally
- Github Issue: Sendouc#1806
@ElementUser
Copy link
Contributor Author

@Sendouc unfortunately, I don't know how to fix the original issue that the reporter reported in the linked issue (#1806), but I thought I would add the cursor lines since that was one of their requested "nice-to-have" features

@Sendouc
Copy link
Owner

Sendouc commented Aug 25, 2024

Hmm I'm not convinced this is an improvement unfortunately. The issue you linked is specifically about plotting the current value. I disabled those lines on hover on the purpose as I find it's redundant with the tooltip.

About BASE_URL that's a valid point if following README instructions does not result in a working env! I will make another issue to explain a bit better what is wrong there (this value should be removed completely)

@Sendouc Sendouc closed this Aug 25, 2024
@Sendouc
Copy link
Owner

Sendouc commented Aug 25, 2024

#1850 here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants