Skip to content

Commit

Permalink
selenium manager: check invalid browser version (#14511)
Browse files Browse the repository at this point in the history
* selenium manager: check invalid browser version

* add more checks

* apply suggestions from reviewer

---------

Co-authored-by: Sri Harsha <[email protected]>
  • Loading branch information
Delta456 and harsha509 authored Oct 4, 2024
1 parent 7a27fe7 commit 9504dcd
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion rust/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -750,7 +750,10 @@ pub trait SeleniumManager {
// Download browser if necessary
match self.download_browser_if_necessary(&original_browser_version) {
Ok(_) => {}
Err(err) => self.check_error_with_driver_in_path(&use_driver_in_path, err)?,
Err(err) => {
self.set_fallback_driver_from_cache(false);
self.check_error_with_driver_in_path(&use_driver_in_path, err)?
}
}

// With the discovered browser version, discover the proper driver version using online endpoints
Expand Down

0 comments on commit 9504dcd

Please sign in to comment.