Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASCII armoring should not require the CRC line #421

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dkg
Copy link
Contributor

@dkg dkg commented Nov 17, 2022

@dkg dkg force-pushed the relax-dearmoring branch from 8ad6e98 to 77aaca7 Compare May 3, 2023 15:12
@bwbroersma
Copy link

Note 1.5 years later and it is still a draft: https://datatracker.ietf.org/doc/draft-ietf-openpgp-crypto-refresh/

Is the CRC checksum required in the current PGP spec?
I'm unsure, RFC 4880 - OpenPGP Message Format § 6 Radix-64 Conversions states:

The checksum with its leading equal sign MAY appear on the first line after the base64 encoded data.

§ 6.2 Forming ASCII Armor is not explicit about the requirement, although it is about the order.

@dkg
Copy link
Contributor Author

dkg commented Jul 9, 2024 via email

@bwbroersma
Copy link

Ok, I checked RFC 4880 for the regex PR I wrote, the current regex and tests are not compliant with that RFC in regard to:

  • not allowing whitespace between the Armor Headers and the cleartext
  • allowing numbers in the Armor Header key names

Maybe recheck those with the draft too.

@dkg
Copy link
Contributor Author

dkg commented Jul 13, 2024

If this is about some other PR, it'd probably be best to point to it, and comment over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants