Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #154

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Version Packages #154

merged 1 commit into from
Oct 13, 2024

Conversation

Sec-ant
Copy link
Owner

@Sec-ant Sec-ant commented Oct 11, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

[email protected]

Patch Changes

  • fa87128: Fix webassembly exception handling. Increase success rate.
  • f1eef5c: Bump zxing-cpp to 81407a0 to fix reader options not being passed to the internal reader if isPure is set.

Summary by CodeRabbit

  • New Features

    • Updated to version 1.2.15 of the zxing-wasm library.
  • Bug Fixes

    • Improved WebAssembly exception handling to enhance success rates.
    • Resolved an issue with reader options not being passed correctly when the isPure flag is set.
  • Documentation

    • Updated CHANGELOG.md to reflect changes and historical updates for the library.

Copy link

coderabbitai bot commented Oct 11, 2024

Walkthrough

The changes in this pull request involve updates to the zxing-wasm library, specifically focusing on versioning and dependency management. The CHANGELOG.md file has been modified to include a new entry for version 1.2.15, documenting two patch changes: one related to WebAssembly exception handling and the other concerning the zxing-cpp dependency update. The package.json file reflects this version bump from 1.2.14 to 1.2.15. Additionally, a file containing a patch note for the library has been deleted.

Changes

File(s) Change Summary
CHANGELOG.md Updated to include version 1.2.15 and details about WebAssembly exception handling and zxing-cpp dependency update.
package.json Version updated from 1.2.14 to 1.2.15; no changes to dependencies or scripts.
Deleted file Removed a patch note related to the zxing-cpp dependency update to commit 81407a0.

Possibly related PRs

  • chore: bump zxing-cpp to d0c1f34 and add pkg.pr.new #103: This PR also involves bumping the zxing-cpp dependency, which is directly related to the changes made in the main PR regarding the update of the zxing-cpp dependency to commit 81407a0.
  • Version Packages #105: Similar to the main PR, this PR documents a patch that includes a bump of the zxing-cpp dependency, indicating a direct connection to the changes made in the main PR.
  • Version Packages #130: This PR includes a change that bumps the zxing-cpp dependency, which aligns with the main PR's focus on updating the dependency.
  • Version Packages #153: This PR documents a version change that includes a patch for a DOM Clobbering vulnerability, which is also mentioned in the main PR's updates to the CHANGELOG.md.

🐇 In the garden where bunnies play,
A version change has come our way.
With zxing-cpp now up to speed,
Our library grows, fulfilling its need.
Hopping forward, we celebrate,
A patch so fine, it's truly great! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between eca4485 and 2f58e65.

📒 Files selected for processing (3)
  • .changeset/nervous-turkeys-brake.md (0 hunks)
  • CHANGELOG.md (1 hunks)
  • package.json (1 hunks)
💤 Files with no reviewable changes (1)
  • .changeset/nervous-turkeys-brake.md
🚧 Files skipped from review as they are similar to previous changes (2)
  • CHANGELOG.md
  • package.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

pkg-pr-new bot commented Oct 11, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/zxing-wasm@154

commit: 7c928d9

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)

3-7: LGTM! Consider adding a link to the referenced commit.

The new changelog entry for version 1.2.15 is well-formatted and provides clear information about the patch change. It accurately reflects the update mentioned in the PR objectives.

To improve traceability, consider adding a link to the referenced zxing-cpp commit. You can modify the line as follows:

- f1eef5c: Bump zxing-cpp to `81407a0` to fix reader options not being passed to the internal reader if `isPure` is set.
+ f1eef5c: Bump zxing-cpp to [`81407a0`](https://github.com/zxing-cpp/zxing-cpp/commit/81407a0) to fix reader options not being passed to the internal reader if `isPure` is set.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between f1eef5c and 7c928d9.

📒 Files selected for processing (3)
  • .changeset/nervous-turkeys-brake.md (0 hunks)
  • CHANGELOG.md (1 hunks)
  • package.json (1 hunks)
💤 Files with no reviewable changes (1)
  • .changeset/nervous-turkeys-brake.md
✅ Files skipped from review due to trivial changes (1)
  • package.json
🧰 Additional context used

@github-actions github-actions bot force-pushed the changeset-release/main branch from 7c928d9 to eca4485 Compare October 12, 2024 02:13
@github-actions github-actions bot force-pushed the changeset-release/main branch from eca4485 to 2f58e65 Compare October 12, 2024 17:23
@Sec-ant Sec-ant merged commit afeeb6a into main Oct 13, 2024
1 check passed
@Sec-ant Sec-ant deleted the changeset-release/main branch October 13, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant