-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #154
Version Packages #154
Conversation
WalkthroughThe changes in this pull request involve updates to the Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)
3-7
: LGTM! Consider adding a link to the referenced commit.The new changelog entry for version 1.2.15 is well-formatted and provides clear information about the patch change. It accurately reflects the update mentioned in the PR objectives.
To improve traceability, consider adding a link to the referenced zxing-cpp commit. You can modify the line as follows:
- f1eef5c: Bump zxing-cpp to `81407a0` to fix reader options not being passed to the internal reader if `isPure` is set. + f1eef5c: Bump zxing-cpp to [`81407a0`](https://github.com/zxing-cpp/zxing-cpp/commit/81407a0) to fix reader options not being passed to the internal reader if `isPure` is set.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
- .changeset/nervous-turkeys-brake.md (0 hunks)
- CHANGELOG.md (1 hunks)
- package.json (1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/nervous-turkeys-brake.md
✅ Files skipped from review due to trivial changes (1)
- package.json
🧰 Additional context used
7c928d9
to
eca4485
Compare
eca4485
to
2f58e65
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
[email protected]
Patch Changes
81407a0
to fix reader options not being passed to the internal reader ifisPure
is set.Summary by CodeRabbit
New Features
zxing-wasm
library.Bug Fixes
isPure
flag is set.Documentation
CHANGELOG.md
to reflect changes and historical updates for the library.