adjusted modify_rotate to preserve nonlinear scale data #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meszaros-lajos-gyorgy
requested changes
Feb 16, 2022
src/js/modifiers.js
Outdated
| let deg = (i + degree) % lines.length | ||
| let index = i - 1 | ||
| rotatedLines[index] = moduloLine(transposeLine(lines[deg], transposer), equave) | ||
| console.log(index) | ||
| console.log(degree) |
There was a problem hiding this comment.
I would recommend cleaning up console.log calls once the development of a feature have been finished.
src/js/modifiers.js
Outdated
| @@ -275,23 +275,24 @@ function modify_rotate() { | |||
| console.log(transposer) | |||
| console.log(equave) | |||
There was a problem hiding this comment.
I know the PR isn't about these lines, but if possible and no longer needed, then please remove these console logs
|
no worries, they were in there previously, but since the sorting issue is resolved I don't think they're needed anymore. |
meszaros-lajos-gyorgy
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #140
Instead of transposing in-place, we start transposing on the line after the new root through the equave. The transposed equave becomes the degree by which you can use to invert the rotation. Then we cycle back to the beginning of the scale and transpose up to the new root. Then we push the original equave to the end of the scale.