Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Colemak-DH support #136

Merged
merged 1 commit into from
Sep 25, 2021
Merged

Conversation

minerscale
Copy link
Contributor

Colemak DH is the most common mod of colemak and either support should be added like this or the ability to upload custom keymaps as json files should be added (happy to try to implement this feature if it's wanted)

Colemak DH is the most common mod of colemak and either support should be added like this or the ability to upload custom keymaps as json files should be added (happy to try to implement this feature if it's wanted)
@vsicurella
Copy link
Collaborator

This would probably be fine, but #124 seeks to remove the dependency on numerous key maps altogether! Once that's finished, we'll automatically support any layout :)

@minerscale
Copy link
Contributor Author

minerscale commented Sep 22, 2021

Actually, I use a momoka_ergo keyboard colemak-dhm programmed directly into the keyboard using qmk, so scancodes are as good as useless for me, I actually need to be able to change the bindings for things. It's a bit of an accessibility nightmare. I've defined a qwerty layer but it's far from convenient (typing becomes very, very hard). So whilst using scancodes much improves the accessibility issue it doesn't entirely fix it.

@SeanArchibald
Copy link
Owner

Thanks for commenting on #124. When moving to scancodes we'll have to remember that some users need a special keymap to fall back to. Not sure exactly how that is going to work but for now I will merge your new keymap into the develop branch and include it as a keymap option.

@SeanArchibald SeanArchibald merged commit 765aeac into SeanArchibald:develop Sep 25, 2021
@SeanArchibald
Copy link
Owner

I've added a menu option so that you can select your new layout. You'll need to pull the changes on the develop branch. Is that working ok for you @minerscale?

@minerscale
Copy link
Contributor Author

I've added a menu option so that you can select your new layout. You'll need to pull the changes on the develop branch. Is that working ok for you @minerscale?

Just tested it, it's working flawlessly. I got the layout right which is good news. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants