-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rank-2 temperament line types #127
Rank-2 temperament line types #127
Conversation
This is a great improvement - I will go through all your PRs some time this week. I'm looking to merge them all into develop and deploy to https://sevish.com/scaleworkshop-dev/ for testing and likely inclusion in the next release Good point about adding a new Modify option to convert all lines to cents/commadecimal. This would be a really simple addition. I added an issue for it #128 and assigned to myself |
Good stuff, this is all merged in and deployed on the dev instance: https://sevish.com/scaleworkshop-dev/ I did make a change to simplifyRatio. Instead of |
Here's a reimplementation of the generate rank-2 temperament feature to preserve line types when possible. I also added an output type if a user still wants to see the scale in cents (or even decimals).
You can easily end up with some crazy ratios this way, which isn't necessarily bad, but it could be useful if there was a 'Modify' option to convert intervals to cents or decimals, if for some reason you made some edits and didn't want to use the generate module again.