-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect Umbra relayer/API version change and force reload #653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit, but otherwise working great. Thank you john!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple small nits then should be good to merge.
fb40c3d
to
1270aea
Compare
1270aea
to
dfe462d
Compare
✅ Deploy Preview for jolly-shaw-20fe62 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dfe462d
to
bc5c9d8
Compare
Coverage after merging frontend-reload-on-api-version-change into master will be
Coverage Report
|
Resolves #309
Added most recently obtained version of Umbra relayer/API to local storage..
At startup, on creation of Umbra relayer/API.. and on every interaction between the front-end and the API.. the API version is returned in the API's response to the front-end, and the version and local storage are used in the following way:
a. The saved API version in local storage is cleared.
b. The user is alerted.
c. The user is forced to reload the front-end web app.
d. On that reload, because the saved version in local storage is not present, the save described in step 2 above will occur.
Currently the alert to the user is just that.. a javascript "alert".. but can probably be done in a more "Vue-centric" way.