-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table enhancements and owner validation #46
base: master
Are you sure you want to change the base?
Conversation
Add OwnersContext Add owner validation Add better wallet loading
PR is a bit big, here's a summary: 1. Contexts
2. Table 3. Other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @radchukd, looking great overall! A couple things I've noticed:
- Sorting seems to be broken. Clicking the headers makes the table flicker, but the sorting order/column does not change
- The "Show N" dropdown works well, but it should only show up if the wallet has more than 5 txs to display. Before that point, it should be hidden.
Add txs count condition for txs count changing Fix sorting table updates Fix txs update from transtaction row
Now also closes #47 |
Hey @radchukd, sorting and threshold button changes looking good! However, I am still seeing the state issues in the UI when switching between wallets. Note how when I start with an empty wallet, switch to one with lots of txs, then navigate back to the empty wallet, I see empty tables displayed. When I refresh, it looks the way it should: |
@radchukd looks like there's a regression on the "Change Threshold" form validation. Not accepting anything other than 1, even when there are multiple owners: |
Oops, the problem was in a totally different place, sorry. I reverted the previous changes and pushed a new commit, should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @radchukd, the state issues I was seeing when navigating between wallets seems to be resolved, though I'm now seeing a similar issue when creating a new tx. Check it out:
@apbendi should be good now. |
Closes #43, #44, #45