Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mise: Add Version 2024.12.22 #6374

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

FilipDeVos
Copy link
Contributor

This pull request adds the manifest to install the "mise-en-place" tool from https://github.com/jdx/mise/

Closes #6329

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@FilipDeVos
Copy link
Contributor Author

/verify

Copy link
Contributor

github-actions bot commented Dec 9, 2024

All changes look good.

Wait for review from human collaborators.

mise

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

1 similar comment
Copy link
Contributor

github-actions bot commented Dec 9, 2024

All changes look good.

Wait for review from human collaborators.

mise

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@FilipDeVos FilipDeVos changed the title mise: Add version 2024.12.3 [email protected]: Add initial version of manifest Dec 9, 2024
@FilipDeVos FilipDeVos changed the title [email protected]: Add initial version of manifest mise: Add version 2024.12.3 Dec 9, 2024
@FilipDeVos FilipDeVos changed the title mise: Add version 2024.12.3 [email protected]: Add manifest Dec 9, 2024
@FilipDeVos
Copy link
Contributor Author

I am trying to do the right thing with the PR title, but the documentation is contradicting.

  • For buckets it says: If it's a new manifest, use : Add version .
  • In the PR template it says: use conventional commits.

@o-l-a-v
Copy link
Contributor

o-l-a-v commented Dec 9, 2024

If we want mise to be purged if scoop uninstall --purge mise, which I guess we do, then add something like:

{
  "post_uninstall": [
        "if ($purge) {",
        "    $Directories = [string[]](",
        "        ('{0}\\mise' -f $env:LOCALAPPDATA),",
        "        ('{0}\\Temp\\mise' -f $env:LOCALAPPDATA)",
        "    )",
        "    $Directories.ForEach{",
        "        if (Test-Path -Path $_ -PathType 'Container') {",
        "            $null = Remove-Item -Path $_ -Recurse -Force",
        "        }",
        "    }",
        "}"
    ]
}

@nagromc
Copy link
Contributor

nagromc commented Dec 9, 2024

I was about to submit a PR; thanks @FilipDeVos!

I suggest two things:

  1. Use a more precise description. The About page is pretty good IMO:

    Development environment setup tool

  2. Use the full name as the app ID: i.e. mise-en-place.json instead of mise.json

@FilipDeVos
Copy link
Contributor Author

I noticed that we need to add $env:LOCALAPPDATA\mise\shims to $env:PATH

I'll research a bit what the best way of doing this is.

@o-l-a-v
Copy link
Contributor

o-l-a-v commented Dec 9, 2024

Scratch this idea

Maybe "post_install" to add it with PowerShell, and "post_uninstall" to remove it? In user context. Something like this (untested):

[System.Environment]::SetEnvironmentVariable(
   'Path',
   ('{0};{1}\mise\shims' -f [System.Environment]::GetEnvironmentVariable('Path','User'), $env:LOCALAPPDATA),
  'User'
)

Edit: Scratch the above, seems Scoop has env_add_path which can be used for this?

@FilipDeVos
Copy link
Contributor Author

env_add_path only supports folders under the installation folder I think.

@FilipDeVos
Copy link
Contributor Author

FilipDeVos commented Dec 9, 2024

I think this commit does the trick.

@FilipDeVos
Copy link
Contributor Author

/verify

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Your changes do not pass checks.

mise-en-place

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@FilipDeVos
Copy link
Contributor Author

/verify

Copy link
Contributor

github-actions bot commented Dec 9, 2024

All changes look good.

Wait for review from human collaborators.

mise-en-place

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@chawyehsu
Copy link
Member

The name mise is available to occupied, it should be used as the manifest name to provide a max consistency if it's used on other pms.

@chawyehsu
Copy link
Member

I am trying to do the right thing with the PR title, but the documentation is contradicting.

  • For buckets it says: If it's a new manifest, use : Add version .
  • In the PR template it says: use conventional commits.

There's no contradicting, Add version could be the PR summary <general summary of the pull request>, [@version] is optional.

  • [email protected]: Add manifest good
  • mise: Add version 2024.12.3 also good
  • Add mise version 2024.12.3 bad
  • Add mise manifest worst

@gatspy
Copy link

gatspy commented Dec 19, 2024

No matches found.
scoop search mise # WARN No matches found.

@nagromc
Copy link
Contributor

nagromc commented Dec 20, 2024

No matches found. scoop search mise # WARN No matches found.

It has not been merged yet.

@MrDwarf7
Copy link

bump - Please merge or advise if there is a routine release schedule.
Winget version already approved & merged but I'd rather not manage packages via the Windows Store lol.

@o-l-a-v
Copy link
Contributor

o-l-a-v commented Dec 30, 2024

@FilipDeVos: The manifest file name is still not mise as both @jdx ( microsoft/winget-pkgs#197444 (comment) ) and @chawyehsu ( #6374 (comment) ) pointed out.

  • Change it from mise-en-place.json back to mise.json?

We can also remove one level of directories by:

{
  "extract_dir": "mise",
  "bin": "bin\\mise.exe"
}

Maybe even two if we don't need LICENSE and README.md? By:

{
  "extract_dir": "mise\\bin",
  "bin": "mise.exe"
}

Edit: mise doctor says to either use PATH or activate, not both. My bad.

Click to view Maybe we also want a note (displayed after install) about how to activate mise. Something like:
{
    "notes": [
        "Mise must be activated/initialized to be able to use all features: https://mise.jdx.dev/cli/activate.html.",
        "\"mise activate --shell pwsh | Out-String | Invoke-Expression\""
    ],
}

Inspiration from:

@FilipDeVos
Copy link
Contributor Author

/verify

Copy link
Contributor

Your changes do not pass checks.

mise

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@FilipDeVos FilipDeVos changed the title [email protected]: Add manifest [email protected]: Add manifest Dec 30, 2024
@FilipDeVos
Copy link
Contributor Author

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

mise

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@FilipDeVos FilipDeVos changed the title [email protected]: Add manifest mise: Add Version 2024.12.22 Dec 30, 2024
@FilipDeVos
Copy link
Contributor Author

/verify

Copy link
Contributor

Your changes do not pass checks.

mise

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@FilipDeVos
Copy link
Contributor Author

/verify

Copy link
Contributor

github-actions bot commented Jan 1, 2025

All changes look good.

Wait for review from human collaborators.

mise

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: mise
8 participants