-
-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mise: Add Version 2024.12.22 #6374
base: master
Are you sure you want to change the base?
Conversation
/verify |
All changes look good. Wait for review from human collaborators. mise
|
1 similar comment
All changes look good. Wait for review from human collaborators. mise
|
I am trying to do the right thing with the PR title, but the documentation is contradicting.
|
If we want mise to be purged if {
"post_uninstall": [
"if ($purge) {",
" $Directories = [string[]](",
" ('{0}\\mise' -f $env:LOCALAPPDATA),",
" ('{0}\\Temp\\mise' -f $env:LOCALAPPDATA)",
" )",
" $Directories.ForEach{",
" if (Test-Path -Path $_ -PathType 'Container') {",
" $null = Remove-Item -Path $_ -Recurse -Force",
" }",
" }",
"}"
]
} |
I was about to submit a PR; thanks @FilipDeVos! I suggest two things:
|
I noticed that we need to add $env:LOCALAPPDATA\mise\shims to $env:PATH I'll research a bit what the best way of doing this is. |
Scratch this ideaMaybe "post_install" to add it with PowerShell, and "post_uninstall" to remove it? In user context. Something like this (untested): [System.Environment]::SetEnvironmentVariable(
'Path',
('{0};{1}\mise\shims' -f [System.Environment]::GetEnvironmentVariable('Path','User'), $env:LOCALAPPDATA),
'User'
) Edit: Scratch the above, seems Scoop has |
env_add_path only supports folders under the installation folder I think. |
I think this commit does the trick. |
/verify |
Your changes do not pass checks. mise-en-place
|
/verify |
All changes look good. Wait for review from human collaborators. mise-en-place
|
The name |
There's no contradicting,
|
No matches found. |
It has not been merged yet. |
bump - Please merge or advise if there is a routine release schedule. |
@FilipDeVos: The manifest file name is still not
We can also remove one level of directories by: {
"extract_dir": "mise",
"bin": "bin\\mise.exe"
} Maybe even two if we don't need {
"extract_dir": "mise\\bin",
"bin": "mise.exe"
} Edit: Click to viewMaybe we also want a note (displayed after install) about how to activate mise. Something like:{
"notes": [
"Mise must be activated/initialized to be able to use all features: https://mise.jdx.dev/cli/activate.html.",
"\"mise activate --shell pwsh | Out-String | Invoke-Expression\""
],
} Inspiration from: |
/verify |
Your changes do not pass checks. mise
|
/verify |
All changes look good. Wait for review from human collaborators. mise
|
/verify |
Your changes do not pass checks. mise
|
/verify |
All changes look good. Wait for review from human collaborators. mise
|
This pull request adds the manifest to install the "mise-en-place" tool from https://github.com/jdx/mise/
Closes #6329
<manifest-name[@version]|chore>: <general summary of the pull request>