SS-698 set default time zone to stockholm time #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to update the studio-settings-configmap.yaml file in serve-charts beacuse of the change in settings.py file. |
|
churnikov
reviewed
Dec 9, 2024
Comment on lines
+42
to
+46
| <td class="d-none d-xxl-table-cell">{{ instance.created_on | date:"d/n/y H:i" }} | ||
| <span | ||
| class="bi bi-clock" data-bs-toggle="tooltip" data-bs-placement="right" data-bs-original-title="{{ objs.timezone }}"> | ||
| </span> | ||
| </td> |
There was a problem hiding this comment.
All in all, lgtm, but wanted to show this as an alternative
There was a problem hiding this comment.
Thanks Nikita. This looks nice, clear, and compact. Shall I implement this one?
There was a problem hiding this comment.
Well, if you like it and have time:)
Otherwise, the current one it also good.
churnikov
approved these changes
Dec 10, 2024
anondo1969
deleted the
SS-698-set-default-time-zone-to-stockholm-time
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Source: https://scilifelab.atlassian.net/browse/SS-698
Checklist
If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Further comments
Anything else you think we should know before merging your code!