-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge pytesting contributions to main #6207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added pytest iris class * actioned majority of review comments * converted remaining functions to camel_case * actioned majority of review comments
[CI Bot] environment lockfiles auto-update
…ncatenate Convert `tests.unit.concatenate.test_concatenate` to pytest.
…besignature Convert to pytest : `lib/iris/tests/unit/concatenate/test__CubeSignature`
* Rewrite result_path. * Review comments.
* pytest migration for unit.common.lenient.test_Lenient * assert order * review actions
…t `request` (#5827) * Rewrite result_path to use the pytest request fixture. * More explicit guidance on the request fixture.
…tory Pytest for /unit/aux_factory_test_AuxCoordFactory
Pytests unit/aux_factory/test_AtmosphereSigmaFactory
* PyTest-compatible check_graphic. * Demonstrate new check_graphic in test_plot. * 7c4f700 * Revert "7c4f7003a" This reverts commit 68f81ac. * Revert "Demonstrate new check_graphic in test_plot." This reverts commit 7c4f700. * Tidy up other unittest references in iris.tests.graphics. * Tidy up other unittest references in iris.tests.graphics. * check_graphic_caller docstring example. * Make check_graphic_caller only accessible from conftest.
Simplify data fixtures.
Convert unit/aux_factory/test_HybridPressureFactory
Convert unit/fileformats/cf to pytest
* pytest migration for unit.common.metadata.test_BaseMetadata * review actions
#5876) * pytest migration of unit.common.metadata.test_metadata_manager_factory * review actions
* Convert root test_util to PyTest. * Convert root test_pp to PyTest. * Review comments - make tests easier to understand.
) * pytest migration of unit.common.metadata.test_CellMeasureMetadata * Update lib/iris/tests/unit/common/metadata/test_CellMeasureMetadata.py Co-authored-by: Patrick Peglar <[email protected]> * Update lib/iris/tests/unit/common/metadata/test_CellMeasureMetadata.py Co-authored-by: Patrick Peglar <[email protected]> * Update lib/iris/tests/unit/common/metadata/test_CellMeasureMetadata.py Co-authored-by: Patrick Peglar <[email protected]> * Update lib/iris/tests/unit/common/metadata/test_CellMeasureMetadata.py Co-authored-by: Patrick Peglar <[email protected]> * review actions --------- Co-authored-by: Patrick Peglar <[email protected]>
* pytest migration of unit.common.metadata.test_CoordMetadata * review actions * Update lib/iris/tests/unit/common/metadata/test_CoordMetadata.py Co-authored-by: Patrick Peglar <[email protected]> --------- Co-authored-by: Patrick Peglar <[email protected]>
* pytest migration of unit.common.resolve.test_Resolve * review actions
github-actions
bot
added
the
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
label
Oct 30, 2024
* upstream/main: (194 commits) Restore latest Whats New files. [pre-commit.ci] pre-commit autoupdate (#6205) correct major minor in whatsnew (#6202) What's new updates for v3.11.0rc0 . (#6201) Update CF standard names table. (#6200) Specify meta in dask.array.map_blocks (#5989) added in a vertical rule for surface fields (#5734) Updated environment lockfiles (#6197) Reduce duplication in cf.py spanning checks. (#6196) Fix attribute array comparison (#6181) Enable factory references to create new dimensions on load. (#6168) (#6194) Improve handling of masks in concatenate (#6187) Demo Numpy v2 (#6035) Bump scitools/workflows from 2024.10.1 to 2024.10.2 (#6186) Document use of new_axis to control merge (#6180) Updated environment lockfiles (#6184) [pre-commit.ci] pre-commit autoupdate (#6175) Updated environment lockfiles (#6183) Update to `cell_method` parsing (#6083) Bump scitools/workflows from 2024.10.0 to 2024.10.1 (#6179) ...
Pytest merge conflicts
⏱️ Performance Benchmark Report: ac8336ePerformance shifts
Full benchmark results
Generated by GHA run |
* Added a draft style guide for iris pytest * most review comments * refactored documentation * fixed doclinks * reslolved review comments * removed excess pages * conversion checklist * pre-lunch changes * majority review requests, rough reshuffle of Test Categories * further reshuffle of Test Categories * review stuffies * fixed a coup of review comments * fixed a doctest failures * reworded function and class intros --------- Co-authored-by: Martin Yeo <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6207 +/- ##
==========================================
- Coverage 89.88% 89.83% -0.05%
==========================================
Files 88 88
Lines 23315 23315
Branches 4338 4338
==========================================
- Hits 20956 20945 -11
- Misses 1628 1644 +16
+ Partials 731 726 -5 ☔ View full report in Codecov by Sentry. |
* added whatsnew entries * corrected _ to - in githubname * whatsnew corrections --------- Co-authored-by: Martin Yeo <[email protected]>
⏱️ Performance Benchmark Report: 44f00d8Performance shifts
Full benchmark results
Generated by GHA run |
⏱️ Performance Benchmark Report: d6a8ae6Performance shifts
Full benchmark results
Generated by GHA run |
50 tasks
trexfeathers
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Part of #6212, Closes #5574
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: