MOI Constraint jacobian-vector fixes #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @baggepinnen |
|
Can you add a test which catches this? |
|
@aml5600 can you add the test, happy to merge it right away once that's added |
aml5600
force-pushed
the
fix/vjp-return
branch
from
e9cfdeb
to
56f4601
Compare
|
@Vaibhavdixit02 sorry for the delay, please let me know if the tests are sufficient. They failed before, passed after the changes. |
lib/OptimizationMOI/test/runtests.jl
Outdated
| y = zeros(2) | ||
| w = ones(1) | ||
| @test MathOptInterface.eval_constraint_jacobian_transpose_product( | ||
| evaluator, y, x, w) isa Any |
There was a problem hiding this comment.
Is it really Any here? I guess since it's inplace it returns nothing?
There was a problem hiding this comment.
I guess it should return nothing? I just have used isa Any on tests that modify inputs to verify that they don't fail. I figured checking the correctness of the return values in y was a bit out of scope for this PR.
There was a problem hiding this comment.
made it explicitly return nothing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
It seems that the methods
MOI.eval_constraint_jacobian_transpose_productandMOI.eval_constraint_jacobian_productwere incorrectly both evaluating the products and erroring when the evaluator possessedcons_vjporcons_jvpfunctions.Add any other context about the problem here.