Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in makedocs #343

Closed
wants to merge 1 commit into from
Closed

typo in makedocs #343

wants to merge 1 commit into from

Conversation

ArnoStrouwen
Copy link
Member

#221 should likely not have been closed.
It likely throws no errors about missing docs because of the typo.

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e722fad) 88.02% compared to head (89692c5) 85.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
- Coverage   88.02%   85.81%   -2.22%     
==========================================
  Files          28       28              
  Lines        2172     2171       -1     
==========================================
- Hits         1912     1863      -49     
- Misses        260      308      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal
Copy link
Member

avik-pal commented Dec 28, 2023

Oops yeah. One thing, though, none of the "not included" ones should be included. Is there a way to pass ignore these.. to makedocs?

@ArnoStrouwen
Copy link
Member Author

I don't think so.
See, JuliaDocs/Documenter.jl#2383.

@avik-pal
Copy link
Member

re-enabled the warnonly argument. Let's wait for JuliaDocs/Documenter.jl#2383 before we can disable it

@avik-pal avik-pal closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants