Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use make_zero and make_zero! in Enzyme extension #1057

Merged
merged 3 commits into from
Jun 9, 2024
Merged

Use make_zero and make_zero! in Enzyme extension #1057

merged 3 commits into from
Jun 9, 2024

Conversation

m-bossart
Copy link
Contributor

Use generic make zero functions from Enzyme.
Mutating make_zero! was introduced in Enzyme v0.12.12
Needed for SciML/NonlinearSolve.jl#439

@m-bossart m-bossart mentioned this pull request Jun 9, 2024
Open
wsmoses
wsmoses approved these changes Jun 9, 2024
View reviewed changes
Copy link
Contributor

@wsmoses wsmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review June 9, 2024 20:06
@ChrisRackauckas ChrisRackauckas merged commit b9f045c into SciML:master Jun 9, 2024
31 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

@wsmoses wsmoses wsmoses approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-bossart @wsmoses @ChrisRackauckas