-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
created a custom-connector folder > custom-connector.md documentation #70
created a custom-connector folder > custom-connector.md documentation #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, please take into account that the point is to teach someone how they can go about implementing a custom connection, also would appreciate it if you can provide a sample full code that is copiable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to place it under the Recipes
section, you can check when rendering.
``` | ||
import { Starknet } from 'starknet.js'; | ||
import { InjectedConnector } from 'starknet.js/connectors/injected'; | ||
import { WebWalletConnector } from 'starknet.js/connectors/webwallet'; | ||
import { QRCodeModal } from '@walletconnect/qrcode-modal'; | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Contents | ||
|
||
1. [Introduction](#introduction) | ||
2. [Install Dependencies](#configure-chains) | ||
3. [Create Custom Connector Class](#create-custom-connector-class) | ||
4. [Implement Wallet Connection Methods](#implement-wallet-connection-methods) | ||
5. [Handle Errors](#handle-errors) | ||
6. [Integrate with User Interface](#integrate-with-user-interface) | ||
7. [Summary](#summary) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we dont need this section
Create a custom connector class that extends the base Starknet connector: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please elaborate futher
Implement methods to handle different types of wallet connections: | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please elaborate futher
gm @mimiprosper how is it going, do be reminded that ODHack is ending today. |
Please do you have materials that can help? There are limited materials/no material about custom wallet connector on starknet. If you have any material that can helpful please send. BurnerWalletConnector not enough resource. Time for this kind of research and work is too short. Thanks. |
you can fix my comments first, aside from the elaboration ones they should be pretty simple. |
here is a short article on what these connectors do: https://www.starknet-react.com/docs/wallets. connector basically are interfaces that abstract away wallet features, The code structure that you wrote within the documentation looks correct. But some adjustments are needed, you can even put the |
I would fix now, am on it. |
|
First, install the necessary packages: | ||
|
||
``` | ||
npm install @scaffold-stark/stark-burner | ||
``` | ||
OR | ||
|
||
``` | ||
yarn add @scaffold-stark/stark-burner | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant breaking down the burner wallet as an example connector ser. not installing it, this would defeat the purpose of the documentation
GM @mimiprosper, seems like we will not be able to finish the PR in due time. Therefore we would not be able to consider this PR as an ODHack 11 PR, but you can still work on it but the rewards will not be part of the ODHack11 reward. Really appreciate the attempt! |
I would work on this task and get it right. Please i need some clarification:
Thanks. |
essentially, the main idea is that we wanted to do no. 3, if you can do 1, that is great, but if you don't know where to start, you can explain how
in this case how to implement one with scaffold so people who want to build wallets can also use scaffold to help them do so. |
Closed due to inactivity |
I have a made Documentation on adding a custom wallet connector.
Fixes #59