Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Ch-1 with the last PR version the Scaffold Stark #181

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Sync Ch-1 with the last PR version the Scaffold Stark #181

merged 3 commits into from
Jan 2, 2025

Conversation

Nadai2010
Copy link
Collaborator

Sync Ch-1 with last version Scaffold Stark

Update ch-1 with last Sync the last update the main and ScaffoldStark

Issue: #180

Types of change

  • Feature
  • Bug
  • Enhancement

Comments (optional)

@Nadai2010 Nadai2010 changed the title Sync last PR Scaffold Stark Sync Ch-1 with last version Scaffold Stark Dec 27, 2024
@Nadai2010 Nadai2010 changed the title Sync Ch-1 with last version Scaffold Stark Sync Ch-1 with the last PR version the Scaffold Stark Dec 27, 2024
metalboyrick
metalboyrick approved these changes Jan 1, 2025
View reviewed changes
Copy link
Collaborator

@metalboyrick metalboyrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality wise looks ok, just remember to check out the comments i left in the base template PR

@Nadai2010 Nadai2010 merged commit 24f54b5 into challenge-1-decentralized-staking Jan 2, 2025
1 check failed
@Nadai2010 Nadai2010 deleted the update/ch-1 branch January 2, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalboyrick metalboyrick metalboyrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nadai2010 @metalboyrick