Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Ch-0 with the last PR version the Scaffold Stark #179

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

Nadai2010
Copy link
Collaborator

@Nadai2010 Nadai2010 commented Dec 27, 2024

Sync Ch-0 with last version Scaffold Stark

Update ch-0 with last Sync the last update the main and ScaffoldStark

Issue: #178

Types of change

  • Feature
  • Bug
  • Enhancement

Comments (optional)

@Nadai2010
Copy link
Collaborator Author

I remind you that the CI actions fail when you do not have the deployedContract YourCollectible, and UI does not find the SC, the same with the other challenges.

image

@metalboyrick
Copy link
Collaborator

The error is caused because the contracts are not present in the deployedContracts.ts file.

Copy link
Collaborator

@metalboyrick metalboyrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality wise looks ok, just remember to check out the comments i left in the base template PR

@Nadai2010 Nadai2010 merged commit 21414fe into challenge-0-simple-nft Jan 2, 2025
1 check failed
@Nadai2010 Nadai2010 deleted the update/ch-0 branch January 2, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants