fix: add staggering to isolate spawning to avoid freezing of app #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix tries to solve the freezing of the app during startup and syncing that happens when a lot of payjoin isolates are spawned at the same time by adding a delay between isolate spawning.
@i5hi I tried this on an Android emulator, where I was able to get the app to freeze during initial syncing and then not have it freeze anymore with this fix, but I think it would be good to have some thorough tests on a real device still before merging by initiating a lot of sessions and making sure it doesn't freeze anymore on startup/resume of the app. If it still freezes, we might need to increase the delay time, but I think it is better to keep it as low as possible so all payjoin sessions can advance as soon as possible when a user opens the app.