Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow down host's subscription status check #17378

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Jan 17, 2025

Problem Statement

It looks like the host's subscribed() property can potentially return wrong value from sys-purpose status.

# subscription-manager status
+-------------------------------------------+
   System Status Details
+-------------------------------------------+
Overall Status: Disabled
Content Access Mode is set to Simple Content Access. This host has access to content, regardless of subscription status.

System Purpose Status: Unknown

All credit goes to @jeremylenz who noticed this!

Solution

We should check the Overall Status specifically.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k test_positive_list_by_last_checkin

@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Jan 17, 2025
@vsedmik vsedmik self-assigned this Jan 17, 2025
@vsedmik
Copy link
Contributor Author

vsedmik commented Jan 17, 2025

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k test_positive_list_by_last_checkin

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9928
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_positive_list_by_last_checkin --external-logging
Test Result : ========= 1 passed, 102 deselected, 111 warnings in 749.95s (0:12:29) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 17, 2025
@vsedmik vsedmik marked this pull request as ready for review January 17, 2025 18:16
@vsedmik vsedmik requested a review from a team as a code owner January 17, 2025 18:16
@vsedmik vsedmik requested a review from jeremylenz January 17, 2025 18:17
@Gauravtalreja1 Gauravtalreja1 added Easy Fix :) Easiest Fix to review and quick merge request. AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing labels Jan 17, 2025
@Gauravtalreja1 Gauravtalreja1 merged commit ce06066 into SatelliteQE:master Jan 17, 2025
16 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 17, 2025
github-actions bot pushed a commit that referenced this pull request Jan 17, 2025
github-actions bot pushed a commit that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request. PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants