-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final changes for light and dark mode change #121
base: master
Are you sure you want to change the base?
Final changes for light and dark mode change #121
Conversation
Added new SVG icons for dark and light mode. Also made some updates to the styles in the SCSS and CSS files.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Untitled.video.-.Made.with.Clipchamp.5.mp4 |
|
All Issue has been resolved. |
@Sanskriti1102 @Krishi1211 Please look at the changes and if no any further changes needed then please merge the PR. |
@Sanskriti1102 @Krishi1211 Please at least give me the feedback on why this pull Request is not being merged |
@Sanskriti1102 @Krishi1211 I hope you're doing well. I just wanted to kindly follow up regarding the pull request I raised a few days ago. If there's any feedback or issues that need to be addressed, I'd appreciate it if you could let me know. I understand there may be some errors, but if possible, I would request you to consider merging it, as it would help me level up on the leaderboard. If it's not feasible to merge at this point, I completely understand. In that case, could you please close the pull request and provide feedback on why it couldn't be merged? That way, I can learn and improve moving forward. |
|
hey @Sanskriti1102 @Krishi1211 this Pull Request is regarding the #issue62 #62 (I created a new Pull Request to avoid any confusion and clash with previous changes on PR #78 ).
Please have a look at the changes and tell iff any further modification needed.
This pull request includes several changes to the
css/style.css
andindex.html
files, primarily focusing on improving the theme toggle functionality and commenting out redundant or unnecessary CSS properties.Theme Toggle Functionality:
lightMode
,darkMode
, andmode
for toggling between light and dark themes. Themode
function is triggered by a button click. (index.html
[1] [2]index.html
index.htmlR354-R371)CSS Simplification:
color
properties across various CSS selectors to simplify the stylesheet and potentially prepare for dynamic theming. (css/style.css
[1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21]HTML Adjustments:
color
properties from elements to align with the new theme toggle functionality. (index.html
[1] [2] [3] [4] [5] [6] [7] [8] [9]General Improvements:
css/style.css
css/style.cssR84)css/style.css
[1] [2] [3]backface-visibility
property to.mfp-with-zoom.mfp-bg
for improved rendering. (css/style.css
css/style.cssR13412)These changes collectively enhance the user experience by providing a theme toggle option and cleaning up the CSS for better maintainability.