Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final changes for light and dark mode change #121

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

coder-writes
Copy link

hey @Sanskriti1102 @Krishi1211 this Pull Request is regarding the #issue62 #62 (I created a new Pull Request to avoid any confusion and clash with previous changes on PR #78 ).
Please have a look at the changes and tell iff any further modification needed.
This pull request includes several changes to the css/style.css and index.html files, primarily focusing on improving the theme toggle functionality and commenting out redundant or unnecessary CSS properties.

Theme Toggle Functionality:

  • Added JavaScript functions lightMode, darkMode, and mode for toggling between light and dark themes. The mode function is triggered by a button click. (index.html [1] [2]
  • Introduced a theme toggle button with SVG icons for light and dark modes. (index.html index.htmlR354-R371)

CSS Simplification:

HTML Adjustments:

  • Removed inline color properties from elements to align with the new theme toggle functionality. (index.html [1] [2] [3] [4] [5] [6] [7] [8] [9]

General Improvements:

  • Ensured text color changes on hover for the invite button. (css/style.css css/style.cssR84)
  • Standardized appearance property for various input types and buttons. (css/style.css [1] [2] [3]
  • Added backface-visibility property to .mfp-with-zoom.mfp-bg for improved rendering. (css/style.css css/style.cssR13412)

These changes collectively enhance the user experience by providing a theme toggle option and cleaning up the CSS for better maintainability.

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ic-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 2:25pm

@coder-writes
Copy link
Author

Untitled.video.-.Made.with.Clipchamp.5.mp4

@Sanskriti1102
Copy link
Owner

image
@coder-writes Theres a merge conflict that has occured, kindly resolve the same !

@coder-writes
Copy link
Author

image @coder-writes Theres a merge conflict that has occured, kindly resolve the same !

All Issue has been resolved.

@coder-writes
Copy link
Author

@Sanskriti1102 @Krishi1211 Please look at the changes and if no any further changes needed then please merge the PR.

@coder-writes
Copy link
Author

@Sanskriti1102 @Krishi1211 Please at least give me the feedback on why this pull Request is not being merged

@coder-writes
Copy link
Author

coder-writes commented Oct 24, 2024

@Sanskriti1102 @Krishi1211 I hope you're doing well. I just wanted to kindly follow up regarding the pull request I raised a few days ago. If there's any feedback or issues that need to be addressed, I'd appreciate it if you could let me know. I understand there may be some errors, but if possible, I would request you to consider merging it, as it would help me level up on the leaderboard.

If it's not feasible to merge at this point, I completely understand. In that case, could you please close the pull request and provide feedback on why it couldn't be merged? That way, I can learn and improve moving forward.

@Sanskriti1102
Copy link
Owner

image
@coder-writes getting conflicts do resolve them asap

@Sanskriti1102
Copy link
Owner

image
file having conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants