Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teams: input split stride is relative to parent #1153

Merged
merged 1 commit into from
Oct 15, 2024
Merged

teams: input split stride is relative to parent #1153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/shmem_team.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,8 @@ int shmem_internal_team_split_strided(shmem_internal_team_t *parent_team, int PE
}

int global_PE_start = shmem_internal_team_pe(parent_team, PE_start);
int global_PE_end = global_PE_start + PE_stride * (PE_size -1);
int global_PE_stride = parent_team->stride * PE_stride;
wrrobin marked this conversation as resolved.
Show resolved Hide resolved
int global_PE_end = global_PE_start + global_PE_stride * (PE_size -1);

if (PE_start < 0 || PE_start >= parent_team->size ||
PE_size <= 0 || PE_size > parent_team->size ||
Expand All @@ -318,7 +319,7 @@ int shmem_internal_team_split_strided(shmem_internal_team_t *parent_team, int PE
}

int my_pe = shmem_internal_pe_in_active_set(shmem_internal_my_pe,
global_PE_start, PE_stride, PE_size);
global_PE_start, global_PE_stride, PE_size);

long *psync = shmem_internal_team_choose_psync(parent_team, REDUCE);
shmem_internal_team_t *myteam = NULL;
Expand All @@ -332,7 +333,7 @@ int shmem_internal_team_split_strided(shmem_internal_team_t *parent_team, int PE

myteam->my_pe = my_pe;
myteam->start = global_PE_start;
myteam->stride = (PE_stride == 0 || PE_size == 1) ? 1 : PE_stride;
myteam->stride = (PE_stride == 0 || PE_size == 1) ? 1 : global_PE_stride;
myteam->size = PE_size;

if (config_mask == 0) {
Expand Down Expand Up @@ -362,7 +363,7 @@ int shmem_internal_team_split_strided(shmem_internal_team_t *parent_team, int PE

shmem_internal_op_to_all(psync_pool_avail_reduced,
psync_pool_avail, N_PSYNC_BYTES, 1,
myteam->start, PE_stride, PE_size, NULL,
myteam->start, global_PE_stride, PE_size, NULL,
psync, SHM_INTERNAL_BAND, SHM_INTERNAL_UCHAR);

/* We cannot release the psync here, because this reduction may not
Expand Down
Loading