Cache memory data in instance #291
Conversation
|
This patch moves the memory caching to instance. Since instance is always in a register, the jit can access is easily. |
zherczeg
force-pushed
the
cache_memory_props
branch
2 times, most recently
from
9477a07 to
8e3ae56
Compare
|
After some trying, the least painful location for the cache is between the memories and globals. |
zherczeg
force-pushed
the
cache_memory_props
branch
from
8e3ae56 to
b526f34
Compare
|
I have updated the patch. Could you check it? Thank you. |
| void enque(Memory* memory); | ||
| void deque(Memory* memory); | ||
|
|
||
| TargetBuffer* next; |
There was a problem hiding this comment.
Is there any specific purpose of this next reference?
It seems that TargetBuffer can be linked to each other like linked-list,
but is it possible that one Memory has multiple TargetBuffers?
There was a problem hiding this comment.
Yes. Each Instance which has a reference to a given Memory has a TargetBuffer connected to that memory. The TargetBuffer is simply a cache, since memory properties rarely changes, and a key resource (memory accesses are very frequent).
src/runtime/Instance.cpp
Outdated
| size_t size = m_module->numberOfMemoryTypes(); | ||
| Memory::TargetBuffer* targetBuffers = reinterpret_cast<Memory::TargetBuffer*>(alignedEnd() + m_module->numberOfMemoryTypes()); |
There was a problem hiding this comment.
m_module->numberOfMemoryTypes() could be replaced by size here
| for (size_t i = 0; i < numberOfMemoryTypes(); i++) { | ||
| targetBuffers[i].enque(instance->m_memories[i]); | ||
| } |
There was a problem hiding this comment.
As here, each Memory has one TargetBuffer and initialized all at once when the Instance is created.
And all TargetBuffer is dequed when the Instance is destoyed.
So, I'm not sure why TargetBuffer has next reference in itself.
There was a problem hiding this comment.
When a Memory grows, it needs to update all TargetBuffers for all Instances. It has a chain list of TargetBuffers, and goes through them. Normally the Instance knows its Memories, but Memories don't know which Instance uses them.
There was a problem hiding this comment.
I see. I missed the point that several TargetBuffers could be created for one Memory when the Memory is shared in multiple Instances.
Signed-off-by: Zoltan Herczeg [email protected]
zherczeg
force-pushed
the
cache_memory_props
branch
from
b526f34 to
d3a6475
Compare
No description provided.