Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NUI] Add value type: color, vector2, shadow #6544

Merged
merged 1 commit into from
Jan 7, 2025
Merged

[NUI] Add value type: color, vector2, shadow #6544

merged 1 commit into from
Jan 7, 2025

Conversation

rabbitfor
Copy link
Collaborator

@rabbitfor rabbitfor commented Jan 6, 2025 •
edited
Loading

Description of Change

Introduce the value type of color, vector2 and shadow. They will replace existing reference types gradually.

API Changes

  • ACR:

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 28, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.LColor

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.LColor Tizen.NUI.LColor::Black

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.LColor Tizen.NUI.LColor::Blue

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.LColor Tizen.NUI.LColor::Green

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.LColor Tizen.NUI.LColor::Red

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.LColor Tizen.NUI.LColor::Transparent

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.LColor Tizen.NUI.LColor::White

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.LColor::A()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.LColor::B()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.LColor::G()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.LColor::R()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.LColor::.ctor(System.Single,System.Single,System.Single,System.Single)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.LColor Tizen.NUI.LColor::MultiplyAlpha(System.Single)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.LColor Tizen.NUI.LColor::WithAlpha(System.Single)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.LShadow

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.LShadow::BlurRadius()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.LColor Tizen.NUI.LShadow::Color()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.LVector2 Tizen.NUI.LShadow::Extents()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.LVector2 Tizen.NUI.LShadow::Offset()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.LShadow::.ctor(System.Single,Tizen.NUI.LColor,Tizen.NUI.LVector2,Tizen.NUI.LVector2)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.LShadow::.ctor(System.Single)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.LVector2

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.LVector2 Tizen.NUI.LVector2::Zero

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.LVector2::Height()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.LVector2::Width()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.LVector2::X()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.LVector2::Y()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.LVector2::.ctor(System.Single,System.Single)

@rabbitfor rabbitfor force-pushed the structTypes branch 2 times, most recently from b0b7585 to a042751 Compare January 6, 2025 12:02
@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 28, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.L.Color

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.L.Color Tizen.NUI.L.Color::Black

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.L.Color Tizen.NUI.L.Color::Blue

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.L.Color Tizen.NUI.L.Color::Green

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.L.Color Tizen.NUI.L.Color::Red

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.L.Color Tizen.NUI.L.Color::Transparent

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.L.Color Tizen.NUI.L.Color::White

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.L.Color::A()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.L.Color::B()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.L.Color::G()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.L.Color::R()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.L.Color::.ctor(System.Single,System.Single,System.Single,System.Single)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.L.Color Tizen.NUI.L.Color::MultiplyAlpha(System.Single)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.L.Color Tizen.NUI.L.Color::WithAlpha(System.Single)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.L.Shadow

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.L.Shadow::BlurRadius()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.L.Color Tizen.NUI.L.Shadow::Color()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.L.Vector2 Tizen.NUI.L.Shadow::Extents()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.L.Vector2 Tizen.NUI.L.Shadow::Offset()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.L.Shadow::.ctor(System.Single,Tizen.NUI.L.Color,Tizen.NUI.L.Vector2,Tizen.NUI.L.Vector2)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.L.Shadow::.ctor(System.Single)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.L.Vector2

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.L.Vector2 Tizen.NUI.L.Vector2::Zero

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.L.Vector2::Height()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.L.Vector2::Width()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.L.Vector2::X()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.L.Vector2::Y()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.L.Vector2::.ctor(System.Single,System.Single)

@everLEEst
Copy link
Contributor

As I locally tested, it works fine when only use Color with using Tizen.NUI.
and also works very well with Color and L.Color.
I suggest one more thing to put them in devel/LiteValue or something similar so all Structed Type gathered in same place we could move them in same place in the public or internal after all.

@rabbitfor
[NUI] Add value type: color, vector2, shadow
7e105df 
Introduce the value type of color, vector2 and shadow.
They will replace existing reference types gradually.

Signed-off-by: Jiyun Yang <[email protected]>
@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 28, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.L.Color

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.L.Color Tizen.NUI.L.Color::Black

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.L.Color Tizen.NUI.L.Color::Blue

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.L.Color Tizen.NUI.L.Color::Green

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.L.Color Tizen.NUI.L.Color::Red

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.L.Color Tizen.NUI.L.Color::Transparent

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.L.Color Tizen.NUI.L.Color::White

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.L.Color::A()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.L.Color::B()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.L.Color::G()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.L.Color::R()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.L.Color::.ctor(System.Single,System.Single,System.Single,System.Single)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.L.Color Tizen.NUI.L.Color::MultiplyAlpha(System.Single)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.L.Color Tizen.NUI.L.Color::WithAlpha(System.Single)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.L.Shadow

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.L.Shadow::BlurRadius()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.L.Color Tizen.NUI.L.Shadow::Color()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.L.Vector2 Tizen.NUI.L.Shadow::Extents()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.L.Vector2 Tizen.NUI.L.Shadow::Offset()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.L.Shadow::.ctor(System.Single,Tizen.NUI.L.Color,Tizen.NUI.L.Vector2,Tizen.NUI.L.Vector2)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.L.Shadow::.ctor(System.Single)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.L.Vector2

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.L.Vector2 Tizen.NUI.L.Vector2::Zero

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.L.Vector2::Height()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.L.Vector2::Width()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.L.Vector2::X()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.L.Vector2::Y()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.L.Vector2::.ctor(System.Single,System.Single)

everLEEst
everLEEst approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@everLEEst everLEEst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

jaehyun0cho
jaehyun0cho approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@jaehyun0cho jaehyun0cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rabbitfor rabbitfor merged commit 26739b8 into Samsung:DevelNUI Jan 7, 2025
3 checks passed
@rabbitfor rabbitfor deleted the structTypes branch January 7, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everLEEst everLEEst everLEEst approved these changes

@jaehyun0cho jaehyun0cho jaehyun0cho approved these changes

@hyunjushin hyunjushin Awaiting requested review from hyunjushin hyunjushin is a code owner

@dongsug-song dongsug-song Awaiting requested review from dongsug-song dongsug-song is a code owner

@Seoyeon2Kim Seoyeon2Kim Awaiting requested review from Seoyeon2Kim Seoyeon2Kim is a code owner

@taehyub taehyub Awaiting requested review from taehyub taehyub is a code owner

@hinohie hinohie Awaiting requested review from hinohie hinohie is a code owner

Assignees
No one assigned
Labels
Devel-NUI Internal API Changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rabbitfor @TizenAPI-Bot @everLEEst @jaehyun0cho