Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUI][API12] Support RemoveIdle API for NUIApplication + Use unified idler callback #6524

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

hinohie
Copy link
Contributor

@hinohie hinohie commented Dec 18, 2024

Let we keep Idler callback list as membery of internal Application class, and allow to remove them during idler callback execute.

Changed Behavior

  • We don't garentee that Delegate function emit time matched with AddIdle function call.
  • We don't allow to add same Delegate function multiple times. Until now, Delegate emitted as the number of AddIdle function call.

…idler callback

Let we keep Idler callback list as membery of internal Application class,
and allow to remove them during idler callback execute.

Signed-off-by: Eunki, Hong <[email protected]>
@github-actions github-actions bot added the API12 Platform : Tizen 9.0 / TFM: net6.0-tizen9.0 label Dec 18, 2024
@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 1, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.NUIApplication::RemoveIdle(System.Delegate)

Copy link
Contributor

@taehyub taehyub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jaehyun0cho jaehyun0cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hinohie hinohie merged commit e44725a into Samsung:API12 Dec 19, 2024
3 checks passed
@hinohie hinohie deleted the remove_idle_support_api12 branch December 19, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API12 Platform : Tizen 9.0 / TFM: net6.0-tizen9.0 Internal API Changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants