[NUI] Support RemoveIdle API for NUIApplication + Use unified idler callback #6523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinohie
requested review from
hyunjushin,
dongsug-song,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst and
rabbitfor
as code owners
Build Error: |
hinohie
force-pushed
the
remove_idle_support
branch
from
d266bf2 to
c870f32
Compare
Internal API ChangedAdded: 1, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.NUIApplication::RemoveIdle(System.Delegate)
|
hinohie
force-pushed
the
remove_idle_support
branch
from
c870f32 to
f8a67a4
Compare
Internal API ChangedAdded: 1, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.NUIApplication::RemoveIdle(System.Delegate)
|
hinohie
force-pushed
the
remove_idle_support
branch
from
f8a67a4 to
4d9c231
Compare
Internal API ChangedAdded: 1, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.NUIApplication::RemoveIdle(System.Delegate)
|
…allback Let we keep Idler callback list as membery of internal Application class, and allow to remove them during idler callback execute. Signed-off-by: Eunki, Hong <[email protected]>
hinohie
force-pushed
the
remove_idle_support
branch
from
4d9c231 to
129f533
Compare
Internal API ChangedAdded: 1, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.NUIApplication::RemoveIdle(System.Delegate)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let we keep Idler callback list as membery of internal Application class, and allow to remove them during idler callback execute.
Changed Behavior
Delegatefunction emit time matched withAddIdlefunction call.Delegatefunction multiple times. Until now,Delegateemitted as the number ofAddIdlefunction call.