[NUI] Add WebView FeedMouseWheel as hidden api #6518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsug-song
requested review from
hyunjushin,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst,
rabbitfor and
hinohie
as code owners
Internal API ChangedAdded: 1, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.WebView::FeedMouseWheel(System.Boolean,System.Int32,System.Int32,System.Int32)
|
dongsug-song
force-pushed
the
api12-1213
branch
from
4846d45 to
29415e4
Compare
Internal API ChangedAdded: 1, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.WebView::FeedMouseWheel(System.Boolean,System.Int32,System.Int32,System.Int32)
|
JoogabYun
reviewed
Dec 16, 2024
| @@ -142,8 +142,10 @@ public void Dispose() | |||
| /// </summary> | |||
| public void Exit() | |||
| { | |||
| Tizen.Log.Error("NUI", "NUICoreBackend.Exit() !"); | |||
There was a problem hiding this comment.
Is the error log level correct?
There was a problem hiding this comment.
Yes, you are correct. However, on the GBM TV target, logs at the error and fatal levels are visible. Due to the request from the GBM user, I had to include debugging logs at the error and fatal levels, although it was not ideal.
There was a problem hiding this comment.
How about adding some comments on why these logs are Error for the history?
There was a problem hiding this comment.
thank you for the review.
I have added some comments by following your review.
There was a problem hiding this comment.
Thanks for updating it ;)
- Add some logs in NUICoreBackend.Exit() by request from GBM
dongsug-song
force-pushed
the
api12-1213
branch
from
29415e4 to
4040ac0
Compare
Internal API ChangedAdded: 1, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.WebView::FeedMouseWheel(System.Boolean,System.Int32,System.Int32,System.Int32)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
[NUI] Add WebView FeedMouseWheel as hidden api
should be released with the following dali patches:
[Tizen] Add WebView FeedMouseWheel as hidden api
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-adaptor/+/316591
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-toolkit/+/316592
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-extension/+/316593
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-csharp-binder/+/316594
Add some logs in NUICoreBackend.Exit() by request from GBM
API Changes
nothing