[NUI] Support PropertyValue set/get without create new Vector2/3/4 #6513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since NUI Vector2 / Vector3 / Vector4 are managed classes, create and dispose them might give overhead sightly. If some memory/performance critical path don't want to create useless temperal Vector234 classes when we get/set PropertyValue, we need to support it. Relative dali patch: https://review.tizen.org/gerrit/c/platform/core/uifw/dali-csharp-binder/+/316151 Signed-off-by: Eunki, Hong <[email protected]>
hinohie
requested review from
hyunjushin,
dongsug-song,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst and
rabbitfor
as code owners
JoogabYun
approved these changes
Dec 11, 2024
dongsug-song
approved these changes
Dec 11, 2024
hinohie
pushed a commit
to hinohie/TizenFX
that referenced
this pull request
Dec 11, 2024
…/3/4 This is cherry-pick patch of Samsung#6513 Since NUI Vector2 / Vector3 / Vector4 are managed classes, create and dispose them might give overhead sightly. If some memory/performance critical path don't want to create useless temperal Vector234 classes when we get/set PropertyValue, we need to support it. Relative dali patch: https://review.tizen.org/gerrit/c/platform/core/uifw/dali-csharp-binder/+/316158 Signed-off-by: Eunki, Hong <[email protected]>
hinohie
pushed a commit
that referenced
this pull request
Dec 11, 2024
…/3/4 This is cherry-pick patch of #6513 Since NUI Vector2 / Vector3 / Vector4 are managed classes, create and dispose them might give overhead sightly. If some memory/performance critical path don't want to create useless temperal Vector234 classes when we get/set PropertyValue, we need to support it. Relative dali patch: https://review.tizen.org/gerrit/c/platform/core/uifw/dali-csharp-binder/+/316158 Signed-off-by: Eunki, Hong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since NUI Vector2 / Vector3 / Vector4 are managed classes, create and dispose them might give overhead sightly.
If some memory/performance critical path don't want to create useless temperal Vector234 classes when we get/set PropertyValue, we need to support it.
Relative dali patch:
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-csharp-binder/+/316151