[NUI] Remove DynamicProperty callback if URL changed + Make more thread safe enough #6504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinohie
requested review from
hyunjushin,
dongsug-song,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst and
rabbitfor
as code owners
Build Error: |
|
@hinohie |
Seoyeon2Kim
reviewed
Dec 10, 2024
|
@hinohie |
hinohie
force-pushed
the
dynamic_bug
branch
2 times, most recently
from
3823df1 to
4a4ea4f
Compare
hinohie
changed the title
|
Hello @Seoyeon2Kim . Thank you for your comments. I check you change PR message more clear. It looks greate! I applied the comments fix, and more, add some sample relative with this PR, and TODO. |
rabbitfor
reviewed
Dec 10, 2024
…ad safe enough Let us remove DynamicProperty callbacks if URL changes. So far, we discard the callbacks if visual was changed. But, the callbacks, which NUI stored, were not removed and remained alive whenever we changed the URL. Let us ensure their removal when URL changed (~= Visual Changed) + To avoid race condition, let we add lock feature before change `InternalSavedDynamicPropertyCallbacks` (Since we can access this dictionary from various threads.) and make `weakReferencesOfLottie` as `ConcurrentDictionary` type. Note : Since we need to iterate by `InternalSavedDynamicPropertyCallbacks.Keys` we need to use lock, instead of `ConcurrentDictionary`. TODO : There are some cases where we don't want to destroy registered callbacks. They will remain active in the future. We make relative sample at `LottieAnimationViewDynamicPropertyTest.cs`. Let we pass `Test4` case show dynmaic property well. Signed-off-by: Eunki, Hong <[email protected]>
Seoyeon2Kim
approved these changes
Dec 10, 2024
rabbitfor
approved these changes
Dec 10, 2024
This was referenced Dec 10, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let us remove
DynamicPropertycallbacks if URL changes.So far, we discard the callbacks if the visual was changed. But, the callbacks, which NUI stored, were not removed and remained alive whenever we changed the URL.
Let us ensure their removal when the URL changes (~= Visual Changed)
To avoid race conditions, let's add a lock feature before changing
InternalSavedDynamicPropertyCallbacks(Since we can access this dictionary from various threads.)TODO : There are some cases where we don't want to destroy registered callbacks. They will remain active in the future.
We make relative sample at
LottieAnimationViewDynamicPropertyTest.cs. Let we passTest4case show dynmaic property well.