[NUI] Make Window events safe while window is being collected #6503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiyun Yang <[email protected]>
Signed-off-by: Jiyun Yang <[email protected]>
Signed-off-by: Jiyun Yang <[email protected]>
rabbitfor
requested review from
hyunjushin,
dongsug-song,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst and
hinohie
as code owners
Internal API ChangedAdded: 2, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseHandle::AddToNativeHolder(System.Object)
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseHandle::RemoveFromNativeHolder(System.Object)
|
Seoyeon2Kim
reviewed
Dec 10, 2024
| } | ||
| } | ||
| } | ||
|
|
||
| void CreateSafeCallback<T>(T method, out T safeCallback) where T : Delegate |
There was a problem hiding this comment.
To maintain consistency with NUI coding rule, could you add internal or private to these functions here?
There was a problem hiding this comment.
Thank you for your comment. I will make another commit to add private keyword because this patch is to sync with this patch in DevelNUI branch so it would not be good to have any changes with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Ref : https://github.sec.samsung.net/NUI/OneUIComponents/issues/6
Make Windows's native event callbacks not collected before native window is released.
Add guard for window callbacks to check disposal.
API Changes