Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TCSACR-596][NUI] Add missing privilege comments #6289

Merged
merged 1 commit into from
Sep 2, 2024
Merged

[TCSACR-596][NUI] Add missing privilege comments #6289

merged 1 commit into from
Sep 2, 2024

Conversation

dongsug-song
Copy link
Contributor

@dongsug-song dongsug-song commented Aug 26, 2024 •
edited
Loading

Description of Change

[NUI] Add missing privilege comments

API Changes

https://jira.sec.samsung.net/browse/TCSACR-596

@TizenAPI-Bot
Copy link
Collaborator

Public API Changed

Please follow the ACR process for the changed API below.

Added: 0, Removed: 0, Changed: 11

Changed

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>3</since_tizen
System.Void Tizen.NUI.NUIApplication::.ctor()

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>9</since_tizen
System.Void Tizen.NUI.NUIApplication::.ctor(System.String,Tizen.NUI.NUIApplication/WindowMode,Tizen.NUI.WindowType)

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>3</since_tizen
System.Void Tizen.NUI.NUIApplication::.ctor(System.String,Tizen.NUI.NUIApplication/WindowMode)

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>3</since_tizen
System.Void Tizen.NUI.NUIApplication::.ctor(System.String)

+ /// <privilege>http://tizen.org/privilege/keygrab</privilege
/// <since_tizen>3</since_tizen
System.Boolean Tizen.NUI.Window::GrabKey(System.Int32,Tizen.NUI.Window/KeyGrabMode)

+ /// <privilege>http://tizen.org/privilege/keygrab</privilege
/// <since_tizen>3</since_tizen
System.Boolean Tizen.NUI.Window::GrabKeyTopmost(System.Int32)

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>3</since_tizen
System.Boolean Tizen.NUI.Window::SetBrightness(System.Int32)

+ /// <privilege>http://tizen.org/privilege/window.priority.set</privilege
/// <since_tizen>3</since_tizen
System.Boolean Tizen.NUI.Window::SetNotificationLevel(Tizen.NUI.NotificationLevel)

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>4</since_tizen
System.Boolean Tizen.NUI.Window::SetScreenOffMode(Tizen.NUI.ScreenOffMode)

+ /// <privilege>http://tizen.org/privilege/keygrab</privilege
/// <since_tizen>3</since_tizen
System.Boolean Tizen.NUI.Window::UngrabKey(System.Int32)

+ /// <privilege>http://tizen.org/privilege/keygrab</privilege
/// <since_tizen>3</since_tizen
System.Boolean Tizen.NUI.Window::UngrabKeyTopmost(System.Int32)

Internal API Changed

Added: 0, Removed: 0, Changed: 12

Changed

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(System.String,Tizen.NUI.NUIApplication/WindowMode,Tizen.Applications.CoreTask)

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(System.String,Tizen.NUI.NUIApplication/WindowMode,Tizen.NUI.Size2D,Tizen.NUI.Position2D,Tizen.Applications.CoreTask)

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>5</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(System.String,Tizen.NUI.NUIApplication/WindowMode,Tizen.NUI.Size2D,Tizen.NUI.Position2D)

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(System.String,Tizen.NUI.Size2D,Tizen.NUI.Position2D,Tizen.NUI.IBorderInterface,Tizen.NUI.NUIApplication/WindowMode)

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>5</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(System.String,Tizen.NUI.Size2D,Tizen.NUI.Position2D)

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>none</since_tizen
[Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(Tizen.NUI.Graphics/BackendType,Tizen.NUI.NUIApplication/WindowMode,Tizen.NUI.Size2D,Tizen.NUI.Position2D,System.String)

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(Tizen.NUI.NUIApplication/ThemeOptions,Tizen.NUI.IBorderInterface)

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(Tizen.NUI.NUIApplication/ThemeOptions,Tizen.NUI.WindowData)

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(Tizen.NUI.NUIApplication/ThemeOptions)

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(Tizen.NUI.Size2D,Tizen.NUI.Position2D,Tizen.NUI.NUIApplication/ThemeOptions,Tizen.NUI.IBorderInterface)

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(Tizen.NUI.Size2D,Tizen.NUI.Position2D,Tizen.NUI.NUIApplication/ThemeOptions)

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>5</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(Tizen.NUI.Size2D,Tizen.NUI.Position2D)

@dongsug-song dongsug-song requested a review from wiertel August 26, 2024 04:27
@dongsug-song
Copy link
Contributor Author

@wiertel
Hello,
this patch shows "ACR Required" tag.
I have just added tag and no interface has been changed.
is it OK to be merged after accepted?
please confirm it.
thank you.

@wiertel
Copy link
Member

wiertel commented Aug 27, 2024

Hello, I agree with the bot. The signatures do no change but the whole API contract is changed a little. Please submit a simple ACR.

@myroot
Copy link
Contributor

myroot commented Aug 27, 2024

http://tizen.org/privilege/display

Allows the application to manage display settings, such as the brightness. This may increase battery consumption.
Type: Native / Dotnet
Level: Public
Privacy: No

왜 NUIApplication생성에 필요한 privilege가 될까요? 필요 없어보이고, 실제로 앱에서 없어도 동작에 문제가 없는데 왜 추가되는 걸까요?

@dongsug-song
Copy link
Contributor Author

http://tizen.org/privilege/display

Allows the application to manage display settings, such as the brightness. This may increase battery consumption.
Type: Native / Dotnet
Level: Public
Privacy: No

왜 NUIApplication생성에 필요한 privilege가 될까요? 필요 없어보이고, 실제로 앱에서 없어도 동작에 문제가 없는데 왜 추가되는 걸까요?

안녕하세요.
확인 감사드립니다.
네. dali 파트에 문의했고 필요 없는것으로 답변 받아서, 제거 하였습니다.

@TizenAPI-Bot
Copy link
Collaborator

Public API Changed

Please follow the ACR process for the changed API below.

Added: 0, Removed: 0, Changed: 7

Changed

+ /// <privilege>http://tizen.org/privilege/keygrab</privilege
/// <since_tizen>3</since_tizen
System.Boolean Tizen.NUI.Window::GrabKey(System.Int32,Tizen.NUI.Window/KeyGrabMode)

+ /// <privilege>http://tizen.org/privilege/keygrab</privilege
/// <since_tizen>3</since_tizen
System.Boolean Tizen.NUI.Window::GrabKeyTopmost(System.Int32)

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>3</since_tizen
System.Boolean Tizen.NUI.Window::SetBrightness(System.Int32)

+ /// <privilege>http://tizen.org/privilege/window.priority.set</privilege
/// <since_tizen>3</since_tizen
System.Boolean Tizen.NUI.Window::SetNotificationLevel(Tizen.NUI.NotificationLevel)

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>4</since_tizen
System.Boolean Tizen.NUI.Window::SetScreenOffMode(Tizen.NUI.ScreenOffMode)

+ /// <privilege>http://tizen.org/privilege/keygrab</privilege
/// <since_tizen>3</since_tizen
System.Boolean Tizen.NUI.Window::UngrabKey(System.Int32)

+ /// <privilege>http://tizen.org/privilege/keygrab</privilege
/// <since_tizen>3</since_tizen
System.Boolean Tizen.NUI.Window::UngrabKeyTopmost(System.Int32)

@dongsug-song dongsug-song changed the title [NUI] Add missing privilege comments [TCSACR-596][NUI] Add missing privilege comments Aug 30, 2024
wiertel
wiertel reviewed Aug 30, 2024
View reviewed changes
src/Tizen.NUI/src/public/Window/Window.cs Outdated
@@ -869,6 +869,8 @@ public void SetInputRegion(Rectangle inputRegion)
/// </summary>
/// <param name="level">The notification window level.</param>
/// <returns>True if no error occurred, false otherwise.</returns>
/// <privilege>http://tizen.org/privilege/window.priority.set</privilege>
/// <exception cref="UnauthorizedAccessException">This exception can be due to permission denied.</exception>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"can be due to..." -> "can be thrown due to..." will sound better, if you decide to change it then change all occurrences

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wiertel
Hello, thank you for the review.
I have changed by following your comment.
please review again. thank you.

@TizenAPI-Bot
Copy link
Collaborator

Public API Changed

Please follow the ACR process for the changed API below.

Added: 0, Removed: 0, Changed: 7

Changed

+ /// <privilege>http://tizen.org/privilege/keygrab</privilege
/// <since_tizen>3</since_tizen
System.Boolean Tizen.NUI.Window::GrabKey(System.Int32,Tizen.NUI.Window/KeyGrabMode)

+ /// <privilege>http://tizen.org/privilege/keygrab</privilege
/// <since_tizen>3</since_tizen
System.Boolean Tizen.NUI.Window::GrabKeyTopmost(System.Int32)

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>3</since_tizen
System.Boolean Tizen.NUI.Window::SetBrightness(System.Int32)

+ /// <privilege>http://tizen.org/privilege/window.priority.set</privilege
/// <since_tizen>3</since_tizen
System.Boolean Tizen.NUI.Window::SetNotificationLevel(Tizen.NUI.NotificationLevel)

+ /// <privilege>http://tizen.org/privilege/display</privilege
/// <since_tizen>4</since_tizen
System.Boolean Tizen.NUI.Window::SetScreenOffMode(Tizen.NUI.ScreenOffMode)

+ /// <privilege>http://tizen.org/privilege/keygrab</privilege
/// <since_tizen>3</since_tizen
System.Boolean Tizen.NUI.Window::UngrabKey(System.Int32)

+ /// <privilege>http://tizen.org/privilege/keygrab</privilege
/// <since_tizen>3</since_tizen
System.Boolean Tizen.NUI.Window::UngrabKeyTopmost(System.Int32)

@dongsug-song dongsug-song requested a review from wiertel September 2, 2024 05:24
Seoyeon2Kim
Seoyeon2Kim approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@Seoyeon2Kim Seoyeon2Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jaehyun0cho
jaehyun0cho approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@jaehyun0cho jaehyun0cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hinohie
hinohie approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@hinohie hinohie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACR Accepted.

@dongsug-song dongsug-song merged commit 90c2f36 into Samsung:DevelNUI Sep 2, 2024
3 checks passed
@dongsug-song dongsug-song deleted the develnui-0826 branch September 2, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seoyeon2Kim Seoyeon2Kim Seoyeon2Kim approved these changes

@jaehyun0cho jaehyun0cho jaehyun0cho approved these changes

@hinohie hinohie hinohie approved these changes

@hyunjushin hyunjushin Awaiting requested review from hyunjushin hyunjushin is a code owner

@taehyub taehyub Awaiting requested review from taehyub taehyub is a code owner

@everLEEst everLEEst Awaiting requested review from everLEEst everLEEst is a code owner

@rabbitfor rabbitfor Awaiting requested review from rabbitfor rabbitfor is a code owner

@wiertel wiertel Awaiting requested review from wiertel

Assignees
No one assigned
Labels
ACR Accepted Devel-NUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dongsug-song @TizenAPI-Bot @wiertel @myroot @hinohie @jaehyun0cho @Seoyeon2Kim