[NUI] Integrate the the applied modifications related to WebView from the previous version (API11) into the current version #6285

dongsug-song · 2024-08-22T04:01:08Z

Description of Change

[NUI] Integrate the the applied modifications related to WebView from the previous version (API11) into the current version

this should be merged with the dali patches below.
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-adaptor/+/316467
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-adaptor/+/316468
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-toolkit/+/316469
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-extension/+/316470
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-extension/+/316471
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-csharp-binder/+/316472
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-csharp-binder/+/316473

API Changes

nothing

- JavascriptMessageHandler callback which has two arguments of msg name and body

TizenAPI-Bot · 2024-08-22T04:07:52Z

Internal API Changed

Added: 23, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.WebView::AddJavaScriptMessageHandler(System.String,Tizen.NUI.BaseComponents.WebView/JavaScriptEntireMessageHandler)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.BaseComponents.WebView/JavaScriptEntireMessageHandler

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.IAsyncResult Tizen.NUI.BaseComponents.WebView/JavaScriptEntireMessageHandler::BeginInvoke(System.String,System.String,System.AsyncCallback,System.Object)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.WebView/JavaScriptEntireMessageHandler::.ctor(System.Object,System.IntPtr)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.WebView/JavaScriptEntireMessageHandler::EndInvoke(System.IAsyncResult)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.WebView/JavaScriptEntireMessageHandler::Invoke(System.String,System.String)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate::PolicyDecisionError()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.WebCertificate::Suspend()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.WebCertificate/PolicyDecisionErrorType

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::AuthorityInvalid

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::CommonNameInvalid

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::DateInvalid

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::Invalid

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::NameViolation

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::NonUniqueName

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::NoRevocationMechanism

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::PinnedKeyNotInChain

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::Revoked

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::UnableToCheckRevocation

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::Unknown

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::ValidityTooLong

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::WeakAlgorithm

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::WeakKey

myroot · 2024-08-22T04:53:01Z

src/Tizen.NUI/src/public/WebView/WebView.cs

+                handlerRootMap[objectName] = handler;
+            }
+            else
+            {
+                handlerRootMap.Add(objectName, handler);


이거 그냥 ContainsKey 검사를 하지 않고

handlerRootMap[objectName] = handler;

항상 이렇게하면 간단하면서 동일한 기능을 하는 코드가 되는것 같습니다.

네. 리뷰 감사합니다. 말씀해주신데로 수정하였습니다.
감사합니다.

TizenAPI-Bot · 2024-08-22T05:43:51Z

Internal API Changed

Added: 23, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.WebView::AddJavaScriptMessageHandler(System.String,Tizen.NUI.BaseComponents.WebView/JavaScriptEntireMessageHandler)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.BaseComponents.WebView/JavaScriptEntireMessageHandler

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.IAsyncResult Tizen.NUI.BaseComponents.WebView/JavaScriptEntireMessageHandler::BeginInvoke(System.String,System.String,System.AsyncCallback,System.Object)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.WebView/JavaScriptEntireMessageHandler::.ctor(System.Object,System.IntPtr)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.WebView/JavaScriptEntireMessageHandler::EndInvoke(System.IAsyncResult)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.WebView/JavaScriptEntireMessageHandler::Invoke(System.String,System.String)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate::PolicyDecisionError()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.WebCertificate::Suspend()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.WebCertificate/PolicyDecisionErrorType

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::AuthorityInvalid

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::CommonNameInvalid

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::DateInvalid

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::Invalid

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::NameViolation

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::NonUniqueName

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::NoRevocationMechanism

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::PinnedKeyNotInChain

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::Revoked

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::UnableToCheckRevocation

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::Unknown

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::ValidityTooLong

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::WeakAlgorithm

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.WebCertificate/PolicyDecisionErrorType Tizen.NUI.WebCertificate/PolicyDecisionErrorType::WeakKey

hinohie

Don't forget to push those dali patches at devel/master

dongsug-song · 2024-08-22T07:13:02Z

Don't forget to push those dali patches at devel/master

Yes, I will definitely do it. Thank you~

jaehyun0cho

LGTM

dongsug-song added 2 commits August 22, 2024 12:39

[NUI] Add WebView Certificate policy decision error get and suspend

9ef2e57

[NUI] Add WebView's JavascriptMessageHandler callback

251b62e

- JavascriptMessageHandler callback which has two arguments of msg name and body

dongsug-song requested review from hyunjushin, Seoyeon2Kim, taehyub, jaehyun0cho, everLEEst, rabbitfor and hinohie as code owners August 22, 2024 04:01

github-actions bot added the Devel-NUI label Aug 22, 2024

dongsug-song force-pushed the develnui-0822 branch from 0544135 to fcc01aa Compare August 22, 2024 04:03

dongsug-song mentioned this pull request Aug 22, 2024

[NUI] Fix the handler's garbage collected exception in WebView #6283

Merged

TizenAPI-Bot added the Internal API Changed label Aug 22, 2024

myroot reviewed Aug 22, 2024

View reviewed changes

[NUI] Fix the handler's garbage collected exception in WebView

9f2d6e7

dongsug-song force-pushed the develnui-0822 branch from fcc01aa to 9f2d6e7 Compare August 22, 2024 05:39

hinohie approved these changes Aug 22, 2024

View reviewed changes

jaehyun0cho approved these changes Aug 22, 2024

View reviewed changes

dongsug-song merged commit 084ae8d into Samsung:DevelNUI Aug 22, 2024
3 checks passed

dongsug-song deleted the develnui-0822 branch August 22, 2024 09:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NUI] Integrate the the applied modifications related to WebView from the previous version (API11) into the current version #6285

[NUI] Integrate the the applied modifications related to WebView from the previous version (API11) into the current version #6285

dongsug-song commented Aug 22, 2024

TizenAPI-Bot commented Aug 22, 2024

Added

myroot Aug 22, 2024

dongsug-song Aug 22, 2024

TizenAPI-Bot commented Aug 22, 2024

Added

hinohie left a comment

dongsug-song commented Aug 22, 2024

jaehyun0cho left a comment

[NUI] Integrate the the applied modifications related to WebView from the previous version (API11) into the current version #6285

[NUI] Integrate the the applied modifications related to WebView from the previous version (API11) into the current version #6285

Conversation

dongsug-song commented Aug 22, 2024

Description of Change

API Changes

TizenAPI-Bot commented Aug 22, 2024

Internal API Changed

Added

myroot Aug 22, 2024

Choose a reason for hiding this comment

dongsug-song Aug 22, 2024

Choose a reason for hiding this comment

TizenAPI-Bot commented Aug 22, 2024

Internal API Changed

Added

hinohie left a comment

Choose a reason for hiding this comment

dongsug-song commented Aug 22, 2024

jaehyun0cho left a comment

Choose a reason for hiding this comment