Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NUI] Add RelativeMotionGrab and RelativeMotionUnGrab #6224

Merged
merged 1 commit into from
Aug 22, 2024
Merged

[NUI] Add RelativeMotionGrab and RelativeMotionUnGrab #6224

merged 1 commit into from
Aug 22, 2024

Conversation

JoogabYun
Copy link
Contributor

@JoogabYun JoogabYun commented Jul 22, 2024 •
edited
Loading

Description of Change

Add RelativeMotionGrab and RelativeMotionUnGrab

[요청사항]

  1. MCF의 Gesture Connection을 지원하기 위해 (참고: https://confluence.sec.samsung.net/pages/viewpage.action?pageId=741952374)
    아래와 같이 ecore_wl2 API를 추가하였습니다. NUI API로 지원 부탁드려도 될까요?
EAPI Eina_Bool ecore_wl2_window_relative_motion_grab(Ecore_Wl2_Window *win);
EAPI Eina_Bool ecore_wl2_window_relative_motion_ungrab(Ecore_Wl2_Window *win);
  1. MC App의 요청사항으로 grab하고자 하는 edge를 argument로 추가하였습니다.
    NUI API로 지원 부탁드립니다.
boundary enum: ECORE_WL2_POINTER_BOUNDARY_TOP/RIGHT/BOTTOM/LEFT
EAPI Eina_Bool ecore_wl2_window_relative_motion_grab(Ecore_Wl2_Window *win, Ecore_Wl2_Pointer_Boundary boundary);
EAPI Eina_Bool ecore_wl2_window_relative_motion_ungrab(Ecore_Wl2_Window *win);

[구현내용]
추가된 ecore api를 window에서 호출할 수 있도록 바인딩 합니다.

https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-adaptor/+/314828/
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-csharp-binder/+/314829/

API Changes

  • ACR:

@JoogabYun JoogabYun force-pushed the RelativeMotionGrap branch from cd782fa to fa0a589 Compare July 22, 2024 01:26
@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 2, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.Window::RelativeMotionGrab()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.Window::RelativeMotionUnGrab()

@JoogabYun JoogabYun force-pushed the RelativeMotionGrap branch from fa0a589 to 94a104e Compare July 25, 2024 01:14
@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 8, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.Window::RelativeMotionGrab(Tizen.NUI.Window/PointerBoundary)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.Window::RelativeMotionUnGrab()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Window/PointerBoundary

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Window/PointerBoundary Tizen.NUI.Window/PointerBoundary::Bottom

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Window/PointerBoundary Tizen.NUI.Window/PointerBoundary::Left

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Window/PointerBoundary Tizen.NUI.Window/PointerBoundary::None

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Window/PointerBoundary Tizen.NUI.Window/PointerBoundary::Right

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Window/PointerBoundary Tizen.NUI.Window/PointerBoundary::Top

@JoogabYun JoogabYun force-pushed the RelativeMotionGrap branch from 94a104e to ab661e8 Compare July 25, 2024 01:50
@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 8, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.Window::RelativeMotionGrab(Tizen.NUI.Window/PointerBoundary)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.Window::RelativeMotionUnGrab()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Window/PointerBoundary

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Window/PointerBoundary Tizen.NUI.Window/PointerBoundary::Bottom

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Window/PointerBoundary Tizen.NUI.Window/PointerBoundary::Left

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Window/PointerBoundary Tizen.NUI.Window/PointerBoundary::None

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Window/PointerBoundary Tizen.NUI.Window/PointerBoundary::Right

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Window/PointerBoundary Tizen.NUI.Window/PointerBoundary::Top

@JoogabYun JoogabYun marked this pull request as ready for review August 22, 2024 00:50
@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 8, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.Window::RelativeMotionGrab(Tizen.NUI.Window/PointerBoundary)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.Window::RelativeMotionUnGrab()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Window/PointerBoundary

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Window/PointerBoundary Tizen.NUI.Window/PointerBoundary::Bottom

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Window/PointerBoundary Tizen.NUI.Window/PointerBoundary::Left

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Window/PointerBoundary Tizen.NUI.Window/PointerBoundary::None

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Window/PointerBoundary Tizen.NUI.Window/PointerBoundary::Right

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Window/PointerBoundary Tizen.NUI.Window/PointerBoundary::Top

jaehyun0cho
jaehyun0cho approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@jaehyun0cho jaehyun0cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoogabYun JoogabYun merged commit 4b76c14 into Samsung:DevelNUI Aug 22, 2024
3 checks passed
@JoogabYun JoogabYun deleted the RelativeMotionGrap branch October 16, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaehyun0cho jaehyun0cho jaehyun0cho approved these changes

@hinohie hinohie hinohie approved these changes

@hyunjushin hyunjushin Awaiting requested review from hyunjushin hyunjushin is a code owner

@dongsug-song dongsug-song Awaiting requested review from dongsug-song dongsug-song is a code owner

@Seoyeon2Kim Seoyeon2Kim Awaiting requested review from Seoyeon2Kim Seoyeon2Kim is a code owner

@taehyub taehyub Awaiting requested review from taehyub taehyub is a code owner

@everLEEst everLEEst Awaiting requested review from everLEEst everLEEst is a code owner

@rabbitfor rabbitfor Awaiting requested review from rabbitfor rabbitfor is a code owner

Assignees
No one assigned
Labels
Devel-NUI Internal API Changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoogabYun @TizenAPI-Bot @hinohie @jaehyun0cho