[NUI] Remove unnecessary comments #5661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since GetLastTouchEvent returns all values regardless of touch or hover, it was separated into GetLastTouchEvent and GetLastHoverEvent. https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-csharp-binder/+/298755/ https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-adaptor/+/298753/ https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-core/+/298752/
ParticleSystem provides 4 classes: ParticleEmitter - emitter of particles ParticleSource - source of particles (spawning new particles) ParticleModifier - controller of particles behaviour Particle - wrapper over particle data
Adds Tizen.NUI.Physics2D.PhysicsAdaptor, Tizen.NUI.Physics2D.PhysicsActor and Tizen.NUI.Physics2D.ScopedAccessor classes. These wrap the DALi physics classes in dali-toolkit; which run the physics integration thread in the Update thread (using the FrameCallback natively). They offer basic APIs for attaching Views to Chipmunk.Body physics objects, so that they can be rendered.
Visual look at same value, Visual.MixColor's alpha and Visual.Opacity, we need to synchronize both values. Since we don't open Visual.Opacity property for View side let we control this value inside of View. Signed-off-by: Eunki, Hong <[email protected]>
…5540) Signed-off-by: Suyeon Hwang <[email protected]>
Signed-off-by: Seoyeon Kim <[email protected]>
To support using new feedback_pattern for da profile, new pattern string and id value is added to Pattern dictionary. Signed-off-by: Yunhee Seo <[email protected]>
…ck type
Allows feedback stop according to feedback type.
This is newly added to System.Feedback.
- public void StopTypeInternal(FeedbackType type)
-> It stops current feedback playing according to feedback type.
Signed-off-by: Yunhee Seo <[email protected]>
…k patterns To support general feedback patterns, newly patterns are added. With these string pattern, it is possible to use mapped feedback patterns from libfeedback. Signed-off-by: Yunhee Seo <[email protected]>
Fix unmatched function binding Signed-off-by: Eunki, Hong <[email protected]>
Window window = NUIApplication.GetDefaultWindow();
window.HoverEvent += OnHover;
private void OnHover(object source, Window.HoverEventArgs e)
{
// e.Hover.GetState(0); // PointStateType.Motion;
}
These determine whether to send touch and hover motion events or not. This is used when the user does not want to receive motion events.
widget need to keep it's instance
Signed-off-by: seungho baek <[email protected]>
Signed-off-by: Jiyun Yang <[email protected]>
Add new request of KVM Service as below: - ReceiveDragData: Request to get current drag data. - CancelDrag: Request to cancel current drag.
* Deprecating Tizen.Location.Geofence APIs Signed-off-by: Priya Kohli <[email protected]> * Removing type Signed-off-by: Priya Kohli <[email protected]> * Indentation fixes Signed-off-by: Priya Kohli <[email protected]> * Modified Note Signed-off-by: Priya Kohli <[email protected]> --------- Signed-off-by: Priya Kohli <[email protected]> Co-authored-by: randeepsingh01 <[email protected]>
The issue is that if you don't keep a reference to the UpdateHookCallback, it may be garbage collected before it is used. UpdateHookCallback should be referenced during used this. Signed-off-by: Changgyu Choi <[email protected]> Co-authored-by: pjh9216 <[email protected]>
Below feedback pattern is supported by mapping feedback pattern id number. - FEEDBACK_PATTERN_WELCOME - FEEDBACK_PATTERN_AUTO_DOOR_OPEN Signed-off-by: Yunhee Seo <[email protected]>
* Deprecating Tizen.Messaging.Email APIs Signed-off-by: Priya Kohli <[email protected]> * Added using System Signed-off-by: Priya Kohli <[email protected]> * Modified Note Signed-off-by: Priya Kohli <[email protected]> --------- Signed-off-by: Priya Kohli <[email protected]> Co-authored-by: randeepsingh01 <[email protected]>
Signed-off-by: Hwankyu Jhun <[email protected]>
The visibility of NUIGadgetResourceManager(NUIGadgetInfo info) is changed to public. Signed-off-by: Hwankyu Jhun <[email protected]>
Signed-off-by: Krishna Kant Jaju <[email protected]> Co-authored-by: randeepsingh01 <[email protected]>
Signed-off-by: Hwankyu Jhun <[email protected]>
The index of sound theme range is 1 ~ N according to conf file. This index range should be considered when using feedback theme index getter/setter. Signed-off-by: Yunhee Seo <[email protected]>
* [WiFi] Fix ASAN crash * [WiFi] Use Marshal.FreeHGlobal() --------- Co-authored-by: chleun-moon <[email protected]>
Use Marshal.FreeHGlobal() instead of Libc.Free() for ASAN environment. Also, remove not any more used Libc.Free() Interop. In ASAN environment, because Interop uses dlopen(), newly opended libc causes different libc/asan alloc context from already allocaed buffer, and it gives segment fault crash when calling Libc.Free(). Signed-off-by: Seung-Woo Kim <[email protected]>
- Use g_free for data allocated by g_malloc Signed-off-by: Wootak Jung <[email protected]>
Seoyeon2Kim
requested review from
hyunjushin,
dongsug-song,
taehyub,
jaehyun0cho,
everLEEst,
rabbitfor and
hinohie
as code owners
- Some comments are legacy codes, and some are already mentioned using `#region` tag. - Make some blank lines for the remarkable readability. Signed-off-by: Seoyeon Kim <[email protected]>
Seoyeon2Kim
force-pushed
the
CleanCode4
branch
from
90daea7 to
f45058f
Compare
dongsug-song
force-pushed
the
DevelNUI
branch
from
b77fce5 to
b422c07
Compare
|
The TizenFX master branch has been changed for API12(tizen_9.0). |
|
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
#regiontag.API Changes