Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUI] Preload some static values #5649

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

hinohie
Copy link
Contributor

@hinohie hinohie commented Oct 24, 2023

Since C# initialize static values when that namespace / class access first time, We need to access some static values at static Preload() timing.

Copy link
Contributor

@dongsug-song dongsug-song left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Great patch!
According to VD's local test, it works. Therefore, preloading does not necessarily require creating a new instance of the class (e.g., View).

Since C# initialize static values when that namespace / class access first time,
We need to access some static values at static Preload() timing.

Signed-off-by: Eunki, Hong <[email protected]>
@hinohie hinohie requested a review from wonrst as a code owner October 24, 2023 05:22
@hinohie hinohie merged commit 366aefa into Samsung:DevelNUI Oct 24, 2023
3 checks passed
@hinohie hinohie deleted the preload_something branch October 24, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants