Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NUI] Public RemoveBinding and ClearBinding api #5634

Merged
merged 1 commit into from
Oct 23, 2023
Merged

[NUI] Public RemoveBinding and ClearBinding api #5634

merged 1 commit into from
Oct 23, 2023

Conversation

elishateng
Copy link
Contributor

@elishateng elishateng commented Oct 17, 2023 •
edited
Loading

Description of Change

  1. Public RemoveBinding and ClearBinding api
  2. Add PropertyChanging invoke for SetValue.

API Changes

  • ACR: None

@github-actions github-actions bot added the API11 Platform : Tizen 8.0 / TFM: net6.0-tizen8.0 label Oct 17, 2023
@elishateng elishateng changed the title Public RemoveBinding api Public RemoveBinding and ClearBinding api Oct 17, 2023
@elishateng elishateng changed the title Public RemoveBinding and ClearBinding api [NUI] Public RemoveBinding and ClearBinding api Oct 17, 2023
@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 2, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.Binding.BindableObject::ClearBinding()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.Binding.BindableObject::RemoveBinding(Tizen.NUI.Binding.BindableProperty)

xuelian-bai
xuelian-bai approved these changes Oct 18, 2023
View reviewed changes
Copy link

@xuelian-bai xuelian-bai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

xiaowei-guan
xiaowei-guan approved these changes Oct 18, 2023
View reviewed changes
Copy link

@xiaowei-guan xiaowei-guan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zg2nets
zg2nets approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@zg2nets zg2nets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

huayongxu
huayongxu approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@huayongxu huayongxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

AchoWang
AchoWang approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@AchoWang AchoWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

hyue7
hyue7 approved these changes Oct 18, 2023
View reviewed changes
Copy link

@hyue7 hyue7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@zhouhao02
Copy link
Contributor

looks good to me

dongsug-song
dongsug-song approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@dongsug-song dongsug-song left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@dongsug-song dongsug-song merged commit 9073ef7 into Samsung:API11 Oct 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyue7 hyue7 hyue7 approved these changes

@xiaowei-guan xiaowei-guan xiaowei-guan approved these changes

@huayongxu huayongxu huayongxu approved these changes

@zg2nets zg2nets zg2nets approved these changes

@dongsug-song dongsug-song dongsug-song approved these changes

@AchoWang AchoWang AchoWang approved these changes

@xuelian-bai xuelian-bai xuelian-bai approved these changes

@hyunjushin hyunjushin Awaiting requested review from hyunjushin hyunjushin is a code owner

@Seoyeon2Kim Seoyeon2Kim Awaiting requested review from Seoyeon2Kim Seoyeon2Kim is a code owner

@taehyub taehyub Awaiting requested review from taehyub taehyub is a code owner

@jaehyun0cho jaehyun0cho Awaiting requested review from jaehyun0cho jaehyun0cho is a code owner

@everLEEst everLEEst Awaiting requested review from everLEEst everLEEst is a code owner

@rabbitfor rabbitfor Awaiting requested review from rabbitfor rabbitfor is a code owner

@hinohie hinohie Awaiting requested review from hinohie hinohie is a code owner

@AdunFang AdunFang Awaiting requested review from AdunFang

Assignees
No one assigned
Labels
API11 Platform : Tizen 8.0 / TFM: net6.0-tizen8.0 Internal API Changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@elishateng @TizenAPI-Bot @zhouhao02 @xuelian-bai @AchoWang @dongsug-song @zg2nets @huayongxu @xiaowei-guan @hyue7