Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NUI] Resolve registry issue for RenderTaskList #5630

Merged
merged 1 commit into from
Oct 17, 2023
Merged

[NUI] Resolve registry issue for RenderTaskList #5630

merged 1 commit into from
Oct 17, 2023

Conversation

hinohie
Copy link
Contributor

@hinohie hinohie commented Oct 17, 2023

After patch #5595 merged, there was some hidden bugs occured. This PR is one of portential bug fix.

@TizenAPI-Bot
Copy link
Collaborator

Build Error:

src/Tizen.NUI/src/internal/Common/RenderTaskList.cs(103,17): error CS0246: The type or namespace name 'HandleRef' could not be found (are you missing a using directive or an assembly reference?) [src/Tizen.NUI/Tizen.NUI.csproj]
src/Tizen.NUI/src/internal/Common/RenderTaskList.cs(103,38): error CS0246: The type or namespace name 'HandleRef' could not be found (are you missing a using directive or an assembly reference?) [src/Tizen.NUI/Tizen.NUI.csproj]
src/Tizen.NUI/src/internal/Common/RenderTaskList.cs(105,28): error CS0246: The type or namespace name 'HandleRef' could not be found (are you missing a using directive or an assembly reference?) [src/Tizen.NUI/Tizen.NUI.csproj]

dongsug-song
dongsug-song approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@dongsug-song dongsug-song left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@Seoyeon2Kim
Copy link
Contributor

Build error! lol

[NUI] Resolve registry issue for RenderTaskList
92c3af2 
After patch Samsung#5595 merged, there was some hidden bugs occured.
This PR is one of portential bug fix.

Signed-off-by: Eunki, Hong <[email protected]>
@hinohie hinohie force-pushed the registry_rendertask branch from 22e7073 to 92c3af2 Compare October 17, 2023 06:37
@hinohie
Copy link
Contributor Author

hinohie commented Oct 17, 2023

Oops! I forgot to push the commit! lol!
Now it compile well.

@hinohie hinohie merged commit 777121f into Samsung:DevelNUI Oct 17, 2023
3 checks passed
@hinohie hinohie deleted the registry_rendertask branch October 17, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongsug-song dongsug-song dongsug-song approved these changes

@hyunjushin hyunjushin Awaiting requested review from hyunjushin hyunjushin is a code owner

@Seoyeon2Kim Seoyeon2Kim Awaiting requested review from Seoyeon2Kim Seoyeon2Kim is a code owner

@taehyub taehyub Awaiting requested review from taehyub taehyub is a code owner

@jaehyun0cho jaehyun0cho Awaiting requested review from jaehyun0cho jaehyun0cho is a code owner

@everLEEst everLEEst Awaiting requested review from everLEEst everLEEst is a code owner

@rabbitfor rabbitfor Awaiting requested review from rabbitfor rabbitfor is a code owner

Assignees
No one assigned
Labels
Devel-NUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hinohie @TizenAPI-Bot @Seoyeon2Kim @dongsug-song