[Applications.WidgetControl] Use Marshal.FreeHGlobal() instead of Lib… #5629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c.Free() Signed-off-by: Inkyun Kil <[email protected]>
Signed-off-by: Inkyun Kil <[email protected]>
devusr-sw-kim
approved these changes
Oct 20, 2023
jaehyun0cho
pushed a commit
that referenced
this pull request
Nov 15, 2023
#5629) * [Applications.WidgetControl] Use Marshal.FreeHGlobal() instead of Libc.Free() Signed-off-by: Inkyun Kil <[email protected]> * [Applications.Cion] Use Marshal.AllocHGlobal() instead of Libc.Malloc() Signed-off-by: Inkyun Kil <[email protected]> --------- Signed-off-by: Inkyun Kil <[email protected]> Co-authored-by: pjh9216 <[email protected]>
devusr-sw-kim
pushed a commit
that referenced
this pull request
Nov 17, 2023
#5629) * [Applications.WidgetControl] Use Marshal.FreeHGlobal() instead of Libc.Free() Signed-off-by: Inkyun Kil <[email protected]> * [Applications.Cion] Use Marshal.AllocHGlobal() instead of Libc.Malloc() Signed-off-by: Inkyun Kil <[email protected]> --------- Signed-off-by: Inkyun Kil <[email protected]> Co-authored-by: pjh9216 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This patch changes using free() to using Marshal.FreeHGlobal().
To avoid crash issues in the asan binary, the library should not use Libc.Free() function directly as possible.