Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Applications.Common] Use Marshal.FreeHGlobal() instead of Libc.Free() #5628

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

hjhun
Copy link
Contributor

@hjhun hjhun commented Oct 17, 2023

Description of Change

This patch changes using free() to using Marshal.FreeHGlobal().
To avoid crash issues in the asan binary, the library should not use Libc.Free() function directly as possible.

@hjhun hjhun requested a review from upple October 17, 2023 04:32
@github-actions github-actions bot added the API12 Platform : Tizen 9.0 / TFM: net6.0-tizen9.0 label Oct 17, 2023
@hjhun hjhun requested a review from pjh9216 October 17, 2023 04:32
Copy link
Collaborator

@upple upple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hjhun hjhun merged commit cd4f4e2 into Samsung:master Oct 17, 2023
3 checks passed
hinohie pushed a commit to hinohie/TizenFX that referenced this pull request Oct 25, 2023
hinohie pushed a commit that referenced this pull request Oct 25, 2023
JoonghyunCho pushed a commit that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API12 Platform : Tizen 9.0 / TFM: net6.0-tizen9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants