Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUI] Fix the SVACE issue. #5627

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

zhouhao02
Copy link
Contributor

Description of Change

Value buttonIcon.ResourceUrlSelector, which is result of method invocation with possible null return value, is dereferenced in constructor of the type StringSelector (passed via parameter buttonIcon.ResourceUrlSelector)

API Changes

  • ACR:

Copy link
Contributor

@huayongxu huayongxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@xuelian-bai xuelian-bai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Contributor

@zg2nets zg2nets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@elishateng elishateng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dongsug-song dongsug-song left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@dongsug-song dongsug-song merged commit ff690d9 into Samsung:DevelNUI Oct 17, 2023
3 checks passed
Copy link
Contributor

@AchoWang AchoWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link

@wanchao-xu wanchao-xu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants