Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUI] Fix some SVACE issues. #5614

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

zhouhao02
Copy link
Contributor

Description of Change

1.CreateValuesVisitor.cs
ArgumentNullException can be thrown inside invocation NameScope.SetNameScope(value as BindableObject, node.Namescope)
WID:14930967 Value value as BindableObject, which was created by as-operator, so can be null, is dereferenced in method call NameScope.SetNameScope()
line 207: NameScope.SetNameScope(value as BindableObject, node.Namescope);
2.DirectRenderingGLView.cs
buffer size may be 0
textures.Count may be 4194241
element byte size may be 8
WID:14929477 Writing textures.Count elements of type System.IntPtr into buffer unmanagedPointer can exceed its size
line 194: System.Runtime.InteropServices.Marshal.Copy(texturesArray, 0, unmanagedPointer, textures.Count);

API Changes

  • ACR:

Copy link

@xuelian-bai xuelian-bai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link

@xiaowei-guan xiaowei-guan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@huayongxu huayongxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@AchoWang AchoWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link

@hyue7 hyue7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Contributor

@elishateng elishateng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongsug-song
Copy link
Contributor

@bshsqa
@tscholb
@huiyueun
@hinohie

Hello,
please review this.
there is chipmunk 3D graphic releated changes.
thank you.

Copy link
Contributor

@hinohie hinohie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello. Fixed code is kind of debug option. And other 2 kind of patches looks no problem.

@dongsug-song dongsug-song merged commit 9a1bebf into Samsung:DevelNUI Oct 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants