-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NUI] Fix some SVACE issues. #5614
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello. Fixed code is kind of debug option. And other 2 kind of patches looks no problem.
Description of Change
1.CreateValuesVisitor.cs
ArgumentNullException can be thrown inside invocation NameScope.SetNameScope(value as BindableObject, node.Namescope)
WID:14930967 Value value as BindableObject, which was created by as-operator, so can be null, is dereferenced in method call NameScope.SetNameScope()
line 207: NameScope.SetNameScope(value as BindableObject, node.Namescope);
2.DirectRenderingGLView.cs
buffer size may be 0
textures.Count may be 4194241
element byte size may be 8
WID:14929477 Writing textures.Count elements of type System.IntPtr into buffer unmanagedPointer can exceed its size
line 194: System.Runtime.InteropServices.Marshal.Copy(texturesArray, 0, unmanagedPointer, textures.Count);
API Changes