Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUI][API10] Unregister callbacks when passed argument is null. #5613

Closed
wants to merge 1 commit into from

Conversation

huayongxu
Copy link
Contributor

@huayongxu huayongxu commented Oct 11, 2023

This patch is merged from DevelNUI:
#5329

The related patch at csharp-binder side:
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-csharp-binder/+/299804/

Description of Change

API Changes

  • ACR:

@github-actions github-actions bot added the API10 Platform : Tizen 7.0 / TFM: tizen10.0 label Oct 11, 2023
Copy link
Contributor

@zg2nets zg2nets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@wb0716 wb0716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me

Copy link

@xuelian-bai xuelian-bai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@zhouhao02
Copy link
Contributor

looks good to me

Copy link
Contributor

@elishateng elishateng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@xiaowei-guan xiaowei-guan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AchoWang AchoWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@elishateng elishateng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huayongxu huayongxu closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API10 Platform : Tizen 7.0 / TFM: tizen10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants