Skip to content

Commit

Permalink
[NUI.Wearable] Remove build warning
Browse files Browse the repository at this point in the history
- Add comment for public API
- Remove some unused private value/method

Signed-off-by: Eunki Hong <[email protected]>
  • Loading branch information
Eunki Hong committed Oct 16, 2023
1 parent 1820fed commit 5853cfa
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 22 deletions.
21 changes: 0 additions & 21 deletions src/Tizen.NUI.Wearable/src/public/CircularPagination.cs
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ public class CircularPagination : Control
private bool isCurrentIndicatorCentered = false; // When the current indicator is the center one, this variable becomes true.
private bool isOddNumber = true;
private bool uninitializedLeftIndicator = true; // Need it when the indicators are asymmetry and the right indicator count is set earlier than left one.
private Animation selectAnimation = null;
private bool isNeedAnimation = false; // TODO : Animation will support using override function later.

Position2D[] oddArray = new Position2D[] { new Position2D(36, 74), new Position2D(47, 60), new Position2D(60, 47), new Position2D(74, 36),
new Position2D(89, 26), new Position2D(105, 18), new Position2D(122, 11), new Position2D(139, 7),
Expand Down Expand Up @@ -203,7 +201,6 @@ public bool IsSymmetrical
}
}


/// <summary>
/// Gets or sets the number of the pages/indicators.
///
Expand Down Expand Up @@ -516,14 +513,6 @@ public virtual void SetIndicatorPosition(int index, Position position)
UpdateVisual();
}

private void CreateSelectAnimation()
{
if (selectAnimation == null)
{
selectAnimation = new Animation(250);
}
}

/// <summary>
/// You can override it to do your select out operation.
/// </summary>
Expand Down Expand Up @@ -593,16 +582,6 @@ protected override void Dispose(DisposeTypes type)

if (type == DisposeTypes.Explicit)
{
if (selectAnimation != null)
{
if (selectAnimation.State == Animation.States.Playing)
{
selectAnimation.Stop();
}
selectAnimation.Dispose();
selectAnimation = null;
}

container.RemoveAll();
indicatorList.Clear();

Expand Down
13 changes: 12 additions & 1 deletion src/Tizen.NUI.Wearable/src/public/RecyclerView/RecyclerView.cs
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@ private void OnItemSizeChanged(object source, PropertyNotification.NotifyEventAr
layoutManager.Layout(ScrollingDirection == Direction.Horizontal ? ContentContainer.CurrentPosition.X : ContentContainer.CurrentPosition.Y);
}

/// <summary>
/// Gets / Sets total number of items.
/// </summary>
/// This may be public opened in tizen_6.0 after ACR done. Before ACR, need to be hidden as inhouse API
[EditorBrowsable(EditorBrowsableState.Never)]
public int TotalItemCount
{
get
Expand Down Expand Up @@ -127,7 +132,11 @@ private void InitializeItems()
}
}


/// <summary>
/// Scrolling direction mode for RecyclerView. <see cref="ScrollableBase.ScrollingDirection"/>.
/// </summary>
/// This may be public opened in tizen_6.0 after ACR done. Before ACR, need to be hidden as inhouse API
[EditorBrowsable(EditorBrowsableState.Never)]
public new Direction ScrollingDirection
{
get
Expand Down Expand Up @@ -253,6 +262,8 @@ protected override float AdjustTargetPositionOfScrollAnimation(float position)
private View focusedView;
private int prevFocusedDataIndex = 0;

/// <inheritdoc/>
[EditorBrowsable(EditorBrowsableState.Never)]
public override View GetNextFocusableView(View currentFocusedView, View.FocusDirection direction, bool loopEnabled)
{
View nextFocusedView = null;
Expand Down
4 changes: 4 additions & 0 deletions src/Tizen.NUI.Wearable/src/public/WearableList.cs
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ public class WearableList : RecyclerView
DecelerationRate = 0.991f;
}

/// <inheritdoc/>
[EditorBrowsable(EditorBrowsableState.Never)]
protected override void SetScrollbar()
{
if(LayoutManager != null)
Expand All @@ -65,6 +67,8 @@ protected override void SetScrollbar()
}
}

/// <inheritdoc/>
[EditorBrowsable(EditorBrowsableState.Never)]
public new RecycleAdapter Adapter
{
get
Expand Down

0 comments on commit 5853cfa

Please sign in to comment.