Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unused frontend modules and fix incorrect UT on backend #296

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

o-kopysov
Copy link
Collaborator

Description

Current PR removes unused frontend modules and fixes incorrect UT on backend.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d1ded3a) 81.69% compared to head (eeb9d47) 81.74%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #296      +/-   ##
============================================
+ Coverage     81.69%   81.74%   +0.04%     
  Complexity      394      394              
============================================
  Files            48       48              
  Lines          1519     1517       -2     
  Branches        182      182              
============================================
- Hits           1241     1240       -1     
+ Misses          198      197       -1     
  Partials         80       80              
Files Coverage Δ
.../main/java/com/lpvs/service/LPVSGitHubService.java 82.17% <ø> (ø)
src/main/java/com/lpvs/service/OAuthService.java 96.87% <100.00%> (+2.75%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Oleg Kopysov <[email protected]>
@o-kopysov o-kopysov self-assigned this Nov 2, 2023
@o-kopysov o-kopysov added the fix label Nov 2, 2023
@o-kopysov o-kopysov marked this pull request as ready for review November 2, 2023 17:51
Copy link
Member

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit 0e95b1a into Samsung:main Nov 3, 2023
7 checks passed
@o-kopysov o-kopysov deleted the fix-run branch November 3, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants