-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Serializing dictionary with ', ", . in key & #37 #38
base: master
Are you sure you want to change the base?
Conversation
Fixes issue where GetTopLevelAndSubKeys splits a key when serializing. Adds test to handle new cases. Does not test cases with mixed " and ' due to issue explained in #57
Ideally fixes SamboyCoding#37, but current implementation has some issues. Will elaborate on issues with this "fix" in a comment.
Easiest way to understand the issue is the test StringTests.EscapedQuotesInAKeyAreValid: The parser is also unable to parse strings in the form "a.b".c or ""a.b"".c, which both are allowed in the toml specification.
|
Added test for redefining dotted key. Made InternalPutValue always have lineNumber since it's used by the parser. Deleted now unused exception.
The current exception thrown here already shows line-number.
I think rider had a field-day when getting to generate Designer.rs Added tests for String Reader since Backtrack wasn't covered. Added test for Document.ToString() Added test for more places it's possible to reach the end of the file. Added test for different ways of writing numbers.
This fix seems to be related to the issue I reported. Is there any ETA for it? |
Fixes issue where GetTopLevelAndSubKeys splits a key when serializing.
Adds test to handle new cases.
Does not test cases with mixed " and ' due to issue explained in #37.