-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sources v2 #465
Sources v2 #465
Conversation
With regards to keyword pattern as they're used in nvim-cmp, my understanding is that sources are not disabled if a match is not found, but rather that matching the keyword pattern is used as another trigger in addition to trigger characters. So to replicate nvim-cmp's mechanism, using Also, I believe nvim-cmp uses lua patterns, not regex. |
I also think that nvim-cmp uses the keyword pattern to define the completion context if a match is found, for reference. |
Ahh super insightful, thanks
I'm thinking we could do something like
And we could ignore this, since sources could mark themselves as incomplete if the default context isn't fine-grained enough for them. We could also expose a helper for getting the match before the cursor for those that need this |
Skipping #313 for now, I'm thinking the existing APIs could be enough. Maybe I'd need to see a specific example where it's needed |
Regression introduced in recent refactoring (Saghen#465) where the path provider was not returning any results. Ensures that all successfully completed stat operations are returned.
Regression introduced in recent refactoring (#465) where the path provider was not returning any results. Ensures that all successfully completed stat operations are returned.
Notes
enabled
since it now runs before each call toget_completions
? CC @stefanboca