-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sonarqube 6.5 support #23
base: master
Are you sure you want to change the base?
Conversation
add support for sonar.sources property containing multiple directories separated by semicolon
fix for maven sending absolute paths and sonar-runner sending relative paths
fix exception while running sonar plugin and coverage is generated for empty module
move language definition to Java file so it can be referenced from other plugins. It didn't work with Scala class (missing Scala runtime on classpath?) Package name is consistent with Sonar convention.
There was no support for collecting Scala class number so I added it. Tested with the unit tests and with SonarQube 6.3.1. Everything seemed OK.
The count of the Scala methods was missing so I added support for this. Tested with unit test
Conform status to
Conform status to
Conform status to
Conform status to |
I don't know what your checker is looking for since it seems to be not working correctly. The build works fine in the other forks and branches. |
I tested it against one of my projects and it works well with 6.7 LTS! |
pom.xml
Outdated
<sonar.pluginKey>scala</sonar.pluginKey> | ||
<sonar.pluginName>Scala</sonar.pluginName> | ||
<sonar.pluginClass>com.sagacify.sonar.scala.ScalaPlugin</sonar.pluginClass> | ||
|
||
<scala.version>2.11.8</scala.version> | ||
<scala.major.version>2.11</scala.major.version> | ||
<scala.version>2.10.7</scala.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pcross616, any particular reason for dropping the minor version to 2.10? The 2.10.x series is no longer actively maintained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might have been a miss take. let me check i honestly dont remember,
@mwz looks like it works fine. There was an issue with scoverage tests in 2.10 to 2.11 but looks resolved. |
4677594
to
3422524
Compare
ok i have updated all the commit messages that I can control. |
are we able to get this published as a build..? |
Hi @pcross616, I wouldn't count on this getting merged any time soon - this repo has been dead for a while now... |
SonarQube 6.5 and greater support
updated unit test
updated CI to use embedded sonarqube install
pulled in #17 and #19