Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonarqube 6.5 support #23

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Sonarqube 6.5 support #23

wants to merge 20 commits into from

Conversation

pcross616
Copy link

SonarQube 6.5 and greater support
updated unit test
updated CI to use embedded sonarqube install
pulled in #17 and #19

Sebastian Chmielewski and others added 10 commits August 17, 2017 11:04
add support for sonar.sources property containing multiple directories
separated by semicolon
fix for maven sending absolute paths and sonar-runner sending relative
paths
fix exception while running sonar plugin and coverage is generated
for empty module
move language definition to Java file so it can be referenced from
other plugins. It didn't work with Scala class
(missing Scala runtime on classpath?)
Package name is consistent with Sonar convention.
There was no support for collecting Scala class number so I
added it. Tested with the unit tests and with SonarQube
6.3.1. Everything seemed OK.
The count of the Scala methods was missing so I
added support for this.
Tested with unit test
@ghost
Copy link

ghost commented Jan 6, 2018

e4cc2df

updated to current version of sonarqube and started fixing some of the tests

Conform status to <type>(<scope>): <subject> pattern
type and scope cannot contain spaces or parenthesis
Shorten status from 76 to 50 characters
Wrap body lines at 72 characters

4466be7

Merge branch 'master' of github.com:sbartram/sonar-scala

Conform status to <type>(<scope>): <subject> pattern
type and scope cannot contain spaces or parenthesis
Shorten status from 56 to 50 characters

ab1a603

Merge branch 'master' into pr19

Conform status to <type>(<scope>): <subject> pattern
type and scope cannot contain spaces or parenthesis

93f1b6e

Merge branch 'master' into pr17

Conform status to <type>(<scope>): <subject> pattern
type and scope cannot contain spaces or parenthesisMore info here

@pcross616
Copy link
Author

I don't know what your checker is looking for since it seems to be not working correctly. The build works fine in the other forks and branches.

@mwz
Copy link

mwz commented Jan 22, 2018

I tested it against one of my projects and it works well with 6.7 LTS!
Any plans to merge this PR and make a release?

pom.xml Outdated
<sonar.pluginKey>scala</sonar.pluginKey>
<sonar.pluginName>Scala</sonar.pluginName>
<sonar.pluginClass>com.sagacify.sonar.scala.ScalaPlugin</sonar.pluginClass>

<scala.version>2.11.8</scala.version>
<scala.major.version>2.11</scala.major.version>
<scala.version>2.10.7</scala.version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pcross616, any particular reason for dropping the minor version to 2.10? The 2.10.x series is no longer actively maintained.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might have been a miss take. let me check i honestly dont remember,

@pcross616
Copy link
Author

@mwz looks like it works fine. There was an issue with scoverage tests in 2.10 to 2.11 but looks resolved.

@pcross616
Copy link
Author

ok i have updated all the commit messages that I can control.

@pcross616
Copy link
Author

are we able to get this published as a build..?

@mwz
Copy link

mwz commented May 5, 2018

Hi @pcross616, I wouldn't count on this getting merged any time soon - this repo has been dead for a while now...
You can find support for the latest LTS version of SonarQube in my fork https://github.com/mwz/sonar-scala.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants