No conversion when delimiter occurs elsewhere too #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pair) to a particular occurrence of a symbol
…miter also occurs elsewhere in the grammar (so it doesn't uniquely delineate the beginning of the production)
…ly non-word chars)
…e added to too many patterns
sungshik
commented
Sep 16, 2024
rascal-textmate-core/src/main/rascal/lang/rascal/grammar/analyze/Delimiters.rsc
Outdated
Show resolved
Hide resolved
rascal-textmate-core/src/main/rascal/lang/textmate/Conversion.rsc
Outdated
Show resolved
Hide resolved
DavyLandman
approved these changes
Sep 23, 2024
rascal-textmate-core/src/main/rascal/lang/rascal/grammar/analyze/Delimiters.rsc
Show resolved
Hide resolved
rascal-textmate-core/src/main/rascal/lang/rascal/grammar/analyze/Delimiters.rsc
Show resolved
Hide resolved
rascal-textmate-core/src/main/rascal/lang/textmate/Conversion.rsc
Outdated
Show resolved
Hide resolved
sungshik
commented
Sep 23, 2024
rascal-textmate-core/src/main/rascal/lang/rascal/grammar/analyze/Delimiters.rsc
Show resolved
Hide resolved
rascal-textmate-core/src/main/rascal/lang/rascal/grammar/analyze/Delimiters.rsc
Show resolved
Hide resolved
rascal-textmate-core/src/main/rascal/lang/textmate/Conversion.rsc
Outdated
Show resolved
Hide resolved
sungshik
deleted the
no-conversion-when-delimiter-occurs-elsewhere-too
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables the conversion of a multi-line production to a multi-line rule (begin/end pattern) when that production begins with a delimiter that also occurs in other unrelated productions (e.g.,
>in Rascal's own grammar). Single-line rules for multi-line productions are still generated (e.g., single-line strings in Rascal are still supported). To do this, this PR:Furthermore, this PR:
execWithCode)