Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimistic conversion as if single line #12

Merged
merged 16 commits into from
Aug 20, 2024

Conversation

sungshik
Copy link
Collaborator

@sungshik sungshik commented Aug 12, 2024

This PR:

  • Disables the check for single-line-ness to optimistically convert multi-line productions to single-line rules
  • To make the optimistic conversion work as expected, adds logic to sort productions based on their starting delimiter (if any)
  • To make the sorting work as expected, refactors and extends the logic to compute inner/outer delimiters of productions
  • Updates existing tests and adds new ones

@sungshik sungshik marked this pull request as ready for review August 12, 2024 10:50
@sungshik sungshik force-pushed the optimistic-conversion-as-if-single-line branch from 6f57aee to 714638a Compare August 13, 2024 20:56
Copy link
Member

@DavyLandman DavyLandman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can understand, it looks good.

Copy link
Collaborator Author

@sungshik sungshik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Davy!

@sungshik sungshik merged commit 36975db into main Aug 20, 2024
2 checks passed
@sungshik sungshik deleted the optimistic-conversion-as-if-single-line branch August 20, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants