Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding instructions to set up k3s #43

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Adding instructions to set up k3s #43

merged 4 commits into from
Jul 31, 2024

Conversation

gbuenodevsuse
Copy link
Collaborator

No description provided.

@gbuenodevsuse gbuenodevsuse requested a review from rtamalin July 30, 2024 19:30
rtamalin
rtamalin reviewed Jul 31, 2024
View reviewed changes
k3s/k3s-init.sh Outdated Show resolved Hide resolved
rtamalin
rtamalin reviewed Jul 31, 2024
View reviewed changes
k3s/k3s-init.sh Outdated Show resolved Hide resolved
rtamalin
rtamalin reviewed Jul 31, 2024
View reviewed changes
k3s/k3s-init.sh Outdated Show resolved Hide resolved
rtamalin
rtamalin requested changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@rtamalin rtamalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor tweak suggestions for the shell script.

Code is good in general.

rtamalin
rtamalin reviewed Jul 31, 2024
View reviewed changes
k3s/k3s-init.sh Outdated Show resolved Hide resolved
gbuenodevsuse and others added 2 commits July 31, 2024 10:41
@gbuenodevsuse @rtamalin
Update k3s/k3s-init.sh
f23bf9b 
Co-authored-by: Fergal Mc Carthy <[email protected]>
@gbuenodevsuse @rtamalin
Update k3s/k3s-init.sh
f57f06a 
Co-authored-by: Fergal Mc Carthy <[email protected]>
@gbuenodevsuse gbuenodevsuse requested a review from rtamalin July 31, 2024 14:06
rtamalin
rtamalin approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@rtamalin rtamalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbuenodevsuse gbuenodevsuse merged commit d1d1d74 into main Jul 31, 2024
1 check passed
@gbuenodevsuse gbuenodevsuse deleted the k3s-setup branch July 31, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtamalin rtamalin rtamalin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbuenodevsuse @rtamalin